From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Sender: rtc-linux@googlegroups.com Received: from mail-lf0-x244.google.com (mail-lf0-x244.google.com. [2a00:1450:4010:c07::244]) by gmr-mx.google.com with ESMTPS id r142si1815427vkf.2.2016.10.18.07.24.57 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 18 Oct 2016 07:24:57 -0700 (PDT) Received: by mail-lf0-x244.google.com with SMTP id b75so32690620lfg.3 for ; Tue, 18 Oct 2016 07:24:57 -0700 (PDT) Date: Tue, 18 Oct 2016 16:24:53 +0200 From: LABBE Corentin To: Alexandre Belloni Cc: a.zummo@towertech.it, lars@metafoo.de, rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org Subject: [rtc-linux] Re: [PATCH v2] rtc: cmos: remove all __exit_p annotations Message-ID: <20161018142453.GA7552@Red> References: <1476791753-1837-1-git-send-email-clabbe.montjoie@gmail.com> <20161018141639.owhkvkn4k2rvgspr@piout.net> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 In-Reply-To: <20161018141639.owhkvkn4k2rvgspr@piout.net> Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , On Tue, Oct 18, 2016 at 04:16:39PM +0200, Alexandre Belloni wrote: > Hi, > > On 18/10/2016 at 13:55:53 +0200, Corentin Labbe wrote : > > Change since v1: > > - restored __exit for module_exit function > > > > ---8<--- > > I don't think this is the proper scissor symbol for git. At least, it is > no recognized by patchwork and messes your patch. > > > From c04a24acebee4b4432afa7a2a7d4cfe114cc9a40 Mon Sep 17 00:00:00 2001 > > From: Corentin Labbe > > Date: Mon, 17 Oct 2016 14:17:49 +0200 > > Subject: [PATCH v2] rtc: cmos: remove all __exit_p annotations > > > > I got the following stack trace under qemu: > > [...] > > When cmos_set_alarm() is called dev is NULL and so trigger the deref via > > cmos->irq > > > > The problem comes from that the device is removed but no remove function > > are called due to _exit_p(). > > > > This patch remove all _exit_p() annotation. > > > > Signed-off-by: Corentin Labbe > > --- > > > The changelog should go here. > > > drivers/rtc/rtc-cmos.c | 10 +++++----- > > 1 file changed, 5 insertions(+), 5 deletions(-) > > Sorry, could I just resent it with PATCH RESENT v2 ? or does I need to bump it to v3. Regards -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761550AbcJROZI (ORCPT ); Tue, 18 Oct 2016 10:25:08 -0400 Received: from mail-lf0-f67.google.com ([209.85.215.67]:35450 "EHLO mail-lf0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752475AbcJROY6 (ORCPT ); Tue, 18 Oct 2016 10:24:58 -0400 Date: Tue, 18 Oct 2016 16:24:53 +0200 From: LABBE Corentin To: Alexandre Belloni Cc: a.zummo@towertech.it, lars@metafoo.de, rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] rtc: cmos: remove all __exit_p annotations Message-ID: <20161018142453.GA7552@Red> References: <1476791753-1837-1-git-send-email-clabbe.montjoie@gmail.com> <20161018141639.owhkvkn4k2rvgspr@piout.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161018141639.owhkvkn4k2rvgspr@piout.net> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 18, 2016 at 04:16:39PM +0200, Alexandre Belloni wrote: > Hi, > > On 18/10/2016 at 13:55:53 +0200, Corentin Labbe wrote : > > Change since v1: > > - restored __exit for module_exit function > > > > ---8<--- > > I don't think this is the proper scissor symbol for git. At least, it is > no recognized by patchwork and messes your patch. > > > From c04a24acebee4b4432afa7a2a7d4cfe114cc9a40 Mon Sep 17 00:00:00 2001 > > From: Corentin Labbe > > Date: Mon, 17 Oct 2016 14:17:49 +0200 > > Subject: [PATCH v2] rtc: cmos: remove all __exit_p annotations > > > > I got the following stack trace under qemu: > > [...] > > When cmos_set_alarm() is called dev is NULL and so trigger the deref via > > cmos->irq > > > > The problem comes from that the device is removed but no remove function > > are called due to _exit_p(). > > > > This patch remove all _exit_p() annotation. > > > > Signed-off-by: Corentin Labbe > > --- > > > The changelog should go here. > > > drivers/rtc/rtc-cmos.c | 10 +++++----- > > 1 file changed, 5 insertions(+), 5 deletions(-) > > Sorry, could I just resent it with PATCH RESENT v2 ? or does I need to bump it to v3. Regards