From: Khem Raj <raj.khem@gmail.com>
To: openembedded-devel@lists.openembedded.org
Subject: [meta-gnome][PATCH 02/16] libbonobo: Fix missing dep on orbit2-native and build with clang
Date: Tue, 18 Oct 2016 22:38:20 -0700 [thread overview]
Message-ID: <20161019053834.11523-2-raj.khem@gmail.com> (raw)
In-Reply-To: <20161019053834.11523-1-raj.khem@gmail.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
meta-gnome/recipes-gnome/bonobo/libbonobo.inc | 2 +-
.../libbonobo/fix-nonliteral-in-string.patch | 26 ++++++++++++++++++++++
.../recipes-gnome/bonobo/libbonobo_2.32.1.bb | 1 +
3 files changed, 28 insertions(+), 1 deletion(-)
create mode 100644 meta-gnome/recipes-gnome/bonobo/libbonobo/fix-nonliteral-in-string.patch
diff --git a/meta-gnome/recipes-gnome/bonobo/libbonobo.inc b/meta-gnome/recipes-gnome/bonobo/libbonobo.inc
index e0f6168..60a8597 100644
--- a/meta-gnome/recipes-gnome/bonobo/libbonobo.inc
+++ b/meta-gnome/recipes-gnome/bonobo/libbonobo.inc
@@ -3,7 +3,7 @@ LICENSE = "GPLv2 & LGPLv2.1"
LIC_FILES_CHKSUM = "file://COPYING;md5=94d55d512a9ba36caa9b7df079bae19f \
file://COPYING.LIB;md5=7fbc338309ac38fefcd64b04bb903e34"
SECTION = "x11/gnome/libs"
-DEPENDS = "glib-2.0 orbit2 intltool-native libxml2 dbus dbus-glib"
+DEPENDS = "glib-2.0 orbit2-native orbit2 intltool-native libxml2 dbus dbus-glib"
inherit gnomebase gtk-doc lib_package
diff --git a/meta-gnome/recipes-gnome/bonobo/libbonobo/fix-nonliteral-in-string.patch b/meta-gnome/recipes-gnome/bonobo/libbonobo/fix-nonliteral-in-string.patch
new file mode 100644
index 0000000..20db671
--- /dev/null
+++ b/meta-gnome/recipes-gnome/bonobo/libbonobo/fix-nonliteral-in-string.patch
@@ -0,0 +1,26 @@
+This checks whether the format string is a literal on the calling function. As bonobo_debug_print()
+takes already a va_list, we specify the format on the functions that call it
+The second number, which is 0 here, should then be the argument index of the variadic argument
+
+Fixed warning with clang
+
+| ../../libbonobo-2.32.1/bonobo/bonobo-debug.c:58:32: error: format string is not a string literal [-Werror,-Wformat-nonliteral]
+| vfprintf (_bonobo_debug_file, fmt, args);
+| ^~~
+| 1 error generated.
+
+Upstream-Status: Pending
+Signed-off-by: Khem Raj <raj.khem@gmail.com>
+
+Index: libbonobo-2.32.1/bonobo/bonobo-debug.c
+===================================================================
+--- libbonobo-2.32.1.orig/bonobo/bonobo-debug.c
++++ libbonobo-2.32.1/bonobo/bonobo-debug.c
+@@ -47,6 +47,7 @@ bonobo_debug_init(void)
+ _bonobo_debug_file = stderr;
+ }
+
++__attribute__((__format__ (printf, 2, 0)))
+ void
+ bonobo_debug_print (const char *name, char *fmt, ...)
+ {
diff --git a/meta-gnome/recipes-gnome/bonobo/libbonobo_2.32.1.bb b/meta-gnome/recipes-gnome/bonobo/libbonobo_2.32.1.bb
index fd4d812..8e00eb4 100644
--- a/meta-gnome/recipes-gnome/bonobo/libbonobo_2.32.1.bb
+++ b/meta-gnome/recipes-gnome/bonobo/libbonobo_2.32.1.bb
@@ -2,6 +2,7 @@ require libbonobo.inc
SRC_URI += "file://0001-Remove-use-of-G_DISABLE_DEPRECATED.patch \
file://do-not-use-srcdir-variable.patch \
+ file://fix-nonliteral-in-string.patch \
"
SRC_URI[archive.md5sum] = "27fa902d4fdf6762ee010e7053aaf77b"
SRC_URI[archive.sha256sum] = "9160d4f277646400d3bb6b4fa73636cc6d1a865a32b9d0760e1e9e6ee624976b"
--
2.10.0
next prev parent reply other threads:[~2016-10-19 5:38 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-19 5:38 [meta-oe][PATCH 01/16] boinc: Add recipe for boinc-client Khem Raj
2016-10-19 5:38 ` Khem Raj [this message]
2016-10-19 20:09 ` [meta-gnome][PATCH 02/16] libbonobo: Fix missing dep on orbit2-native and build with clang akuster808
2016-10-20 2:45 ` Khem Raj
2016-10-19 5:38 ` [meta-oe][PATCH 03/16] libmbim: Fix " Khem Raj
2016-10-19 5:38 ` [meta-oe][PATCH 04/16] libplist: Squash warnings found by clang Khem Raj
2016-10-19 5:38 ` [meta-oe][PATCH 05/16] frame: Fix build with clang Khem Raj
2016-10-19 5:38 ` [meta-python][PATCH 06/16] python-greenlet: Rename register from rX to xX for aarch64 Khem Raj
2016-10-19 5:38 ` [meta-multimedia][PATCH 07/16] libdc1394: Upgrade to 2.2.4 Khem Raj
2016-10-19 5:38 ` [meta-networking][PATCH 08/16] lowpan-tools: Fix errors found with clang Khem Raj
2016-10-19 5:38 ` [meta-oe][PATCH 09/16] gpm: Remove nested functions Khem Raj
2016-10-19 5:38 ` [meta-oe][PATCH 10/16] flashrom: Fix build with clang and aarch64 Khem Raj
2016-10-19 5:38 ` [meta-networking][PATCH 11/16] openl2tp: Fix build with clang Khem Raj
2016-10-19 5:38 ` [meta-oe][PATCH 12/16] glcompbench: Demand c++11 explicitly Khem Raj
2016-10-19 5:38 ` [meta-oe][PATCH 13/16] joe: Fix build with clang Khem Raj
2016-10-19 5:38 ` [meta-oe][PATCH 14/16] fwts: Update to 16.09 release Khem Raj
2016-10-25 13:29 ` Martin Jansa
2016-10-19 5:38 ` [meta-networking][PATCH 15/16] libmnl, nftables: Update versions Khem Raj
2016-10-19 5:38 ` [meta-oe][PATCH 16/16] mg: Update to 20161005 Khem Raj
2016-10-19 20:06 ` [meta-oe][PATCH 01/16] boinc: Add recipe for boinc-client akuster808
2016-10-25 13:32 ` Martin Jansa
2016-10-25 13:49 ` Khem Raj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161019053834.11523-2-raj.khem@gmail.com \
--to=raj.khem@gmail.com \
--cc=openembedded-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.