From: Mauro Carvalho Chehab <mchehab@s-opensource.com>
To: Takashi Sakamoto <o-takashi@sakamocchi.jp>,
Stefan Richter <stefanr@s5r6.in-berlin.de>
Cc: Linux Media Mailing List <linux-media@vger.kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux1394-devel@lists.sourceforge.net,
Mauro Carvalho Chehab <mchehab@infradead.org>
Subject: Re: [PATCH v2 53/58] firewire: don't break long lines
Date: Wed, 19 Oct 2016 08:19:20 -0200 [thread overview]
Message-ID: <20161019081920.15b97eb7@vento.lan> (raw)
In-Reply-To: <84c06fb2-d147-689d-8d42-ce6b1f400a1f@sakamocchi.jp>
Em Wed, 19 Oct 2016 08:03:01 +0900
Takashi Sakamoto <o-takashi@sakamocchi.jp> escreveu:
> From: Takashi Sakamoto <o-takashi@sakamocchi.jp>
> Date: Wed, 19 Oct 2016 07:53:35 +0900
> Subject: [PATCH] [media] firewire: use dev_dbg() instead of printk()
>
> A structure for firedtv (struct firedtv) has a member for a pointer to
> struct device. In this case, we can use dev_dbg() for debug printing.
> This is more preferrable behaviour in device driver development.
>
> Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
> ---
> drivers/media/firewire/firedtv-rc.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/firewire/firedtv-rc.c
> b/drivers/media/firewire/firedtv-rc.c
> index f82d4a9..04dea2a 100644
> --- a/drivers/media/firewire/firedtv-rc.c
> +++ b/drivers/media/firewire/firedtv-rc.c
> @@ -184,8 +184,9 @@ void fdtv_handle_rc(struct firedtv *fdtv, unsigned int code)
> else if (code >= 0x4540 && code <= 0x4542)
> code = oldtable[code - 0x4521];
> else {
> - printk(KERN_DEBUG "firedtv: invalid key code 0x%04x "
> - "from remote control\n", code);
> + dev_dbg(fdtv->device,
> + "invalid key code 0x%04x from remote control\n",
> + code);
> return;
> }
Looks good to me. Applied to my development tree:
https://git.linuxtv.org/mchehab/experimental.git/commit/?h=printk&id=e0de6d90145753bf40415d670471fcc536b2a26c
https://git.linuxtv.org/mchehab/experimental.git/commit/?h=printk&id=9532ba4af6a7619bb028ddd3b829e6f163917b79
Stefan,
Would the above be OK for you?
Thanks,
Mauro
next prev parent reply other threads:[~2016-10-19 15:08 UTC|newest]
Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-18 20:45 [PATCH v2 00/58] don't break long lines on strings Mauro Carvalho Chehab
2016-10-18 20:45 ` [PATCH v2 01/58] b2c2: don't break long lines Mauro Carvalho Chehab
2016-10-18 20:45 ` [PATCH v2 02/58] cx25840: " Mauro Carvalho Chehab
2016-10-18 20:45 ` [PATCH v2 03/58] smiapp: " Mauro Carvalho Chehab
2016-10-18 20:45 ` [PATCH v2 04/58] soc_camera: " Mauro Carvalho Chehab
2016-10-18 20:45 ` [PATCH v2 05/58] b2c2: " Mauro Carvalho Chehab
2016-10-18 20:45 ` [PATCH v2 06/58] bt8xx: " Mauro Carvalho Chehab
2016-10-18 20:45 ` [PATCH v2 07/58] cx18: " Mauro Carvalho Chehab
2016-10-18 20:45 ` [PATCH v2 08/58] cx23885: " Mauro Carvalho Chehab
2016-10-19 7:36 ` Hans Verkuil
2016-10-18 20:45 ` [PATCH v2 09/58] cx88: " Mauro Carvalho Chehab
2016-10-18 20:45 ` [PATCH v2 10/58] ddbridge: " Mauro Carvalho Chehab
2016-10-18 20:45 ` [PATCH v2 11/58] dm1105: " Mauro Carvalho Chehab
2016-10-18 20:45 ` [PATCH v2 12/58] ivtv: " Mauro Carvalho Chehab
2016-10-18 20:45 ` [PATCH v2 13/58] meye: " Mauro Carvalho Chehab
2016-10-18 20:45 ` [PATCH v2 14/58] pt1: " Mauro Carvalho Chehab
2016-10-18 20:45 ` [PATCH v2 15/58] saa7134: " Mauro Carvalho Chehab
2016-10-18 20:45 ` [PATCH v2 16/58] saa7164: " Mauro Carvalho Chehab
2016-10-18 20:45 ` [PATCH v2 17/58] solo6x10: " Mauro Carvalho Chehab
2016-10-18 20:45 ` [PATCH v2 18/58] ttpci: " Mauro Carvalho Chehab
2016-10-18 20:45 ` [PATCH v2 19/58] tw68: " Mauro Carvalho Chehab
2016-10-18 20:45 ` [PATCH v2 20/58] davinci: " Mauro Carvalho Chehab
2016-10-18 20:45 ` [PATCH v2 21/58] exynos4-is: " Mauro Carvalho Chehab
2016-10-18 20:45 ` Mauro Carvalho Chehab
2016-10-18 20:45 ` [PATCH v2 22/58] marvell-ccic: " Mauro Carvalho Chehab
2016-10-18 20:45 ` [PATCH v2 23/58] omap: " Mauro Carvalho Chehab
2016-10-18 20:45 ` [PATCH v2 24/58] omap3isp: " Mauro Carvalho Chehab
2016-10-18 20:45 ` [PATCH v2 25/58] s5p-mfc: " Mauro Carvalho Chehab
2016-10-18 20:45 ` Mauro Carvalho Chehab
2016-10-18 20:45 ` [PATCH v2 26/58] c8sectpfe: " Mauro Carvalho Chehab
2016-10-18 20:45 ` Mauro Carvalho Chehab
2016-10-18 20:45 ` [PATCH v2 27/58] ti-vpe: " Mauro Carvalho Chehab
2016-10-18 20:45 ` [PATCH v2 28/58] si470x: " Mauro Carvalho Chehab
2016-10-18 20:45 ` [PATCH v2 29/58] si4713: " Mauro Carvalho Chehab
2016-10-18 20:45 ` [PATCH v2 30/58] wl128x: " Mauro Carvalho Chehab
2016-10-18 20:45 ` [PATCH v2 31/58] au0828: " Mauro Carvalho Chehab
2016-10-18 20:45 ` [PATCH v2 32/58] b2c2: " Mauro Carvalho Chehab
2016-10-18 20:45 ` [PATCH v2 33/58] cpia2: " Mauro Carvalho Chehab
2016-10-18 20:45 ` [PATCH v2 34/58] cx231xx: " Mauro Carvalho Chehab
2016-10-18 20:45 ` [PATCH v2 35/58] dvb-usb: " Mauro Carvalho Chehab
2016-10-18 20:45 ` [PATCH v2 36/58] dvb-usb-v2: " Mauro Carvalho Chehab
2016-10-18 20:45 ` [PATCH v2 37/58] em28xx: " Mauro Carvalho Chehab
2016-10-18 20:45 ` [PATCH v2 38/58] gspca: " Mauro Carvalho Chehab
2016-10-18 20:45 ` [PATCH v2 39/58] hdpvr: " Mauro Carvalho Chehab
2016-10-18 20:45 ` [PATCH v2 40/58] pvrusb2: " Mauro Carvalho Chehab
2016-10-18 20:45 ` [PATCH v2 41/58] pwc: " Mauro Carvalho Chehab
2016-10-18 20:45 ` [PATCH v2 42/58] siano: " Mauro Carvalho Chehab
2016-10-18 20:45 ` [PATCH v2 43/58] stkwebcam: " Mauro Carvalho Chehab
2016-10-18 20:45 ` [PATCH v2 44/58] tm6000: " Mauro Carvalho Chehab
2016-10-18 20:45 ` [PATCH v2 45/58] ttusb-budget: " Mauro Carvalho Chehab
2016-10-18 20:45 ` [PATCH v2 46/58] ttusb-dec: " Mauro Carvalho Chehab
2016-10-18 20:45 ` [PATCH v2 47/58] usbvision: " Mauro Carvalho Chehab
2016-10-18 20:46 ` [PATCH v2 48/58] uvc: " Mauro Carvalho Chehab
2016-10-20 11:06 ` Laurent Pinchart
2016-10-21 10:13 ` Mauro Carvalho Chehab
2016-10-18 20:46 ` [PATCH v2 49/58] zr364xx: " Mauro Carvalho Chehab
2016-10-18 20:46 ` [PATCH v2 50/58] v4l2-core: " Mauro Carvalho Chehab
2016-10-19 7:09 ` Sakari Ailus
2016-10-19 9:56 ` Mauro Carvalho Chehab
2016-10-18 20:46 ` [PATCH v2 51/58] dvb-frontends: " Mauro Carvalho Chehab
2016-10-18 20:46 ` [PATCH v2 52/58] common: " Mauro Carvalho Chehab
2016-10-18 20:46 ` [PATCH v2 53/58] firewire: " Mauro Carvalho Chehab
2016-10-18 23:03 ` Takashi Sakamoto
2016-10-19 7:56 ` Stefan Richter
2016-10-19 10:20 ` Mauro Carvalho Chehab
2016-10-19 10:19 ` Mauro Carvalho Chehab [this message]
2016-10-19 22:55 ` Stefan Richter
[not found] ` <20161019100113.077e60f1@kant>
2016-10-19 10:10 ` Mauro Carvalho Chehab
2016-10-18 20:46 ` [PATCH v2 54/58] i2c: " Mauro Carvalho Chehab
2016-10-19 18:16 ` Lad, Prabhakar
2016-10-20 10:46 ` Laurent Pinchart
2016-10-21 10:25 ` Mauro Carvalho Chehab
2016-10-18 20:46 ` [PATCH v2 55/58] platform: " Mauro Carvalho Chehab
2016-10-18 20:46 ` [PATCH v2 56/58] radio: " Mauro Carvalho Chehab
2016-10-18 20:46 ` [PATCH v2 57/58] rc: " Mauro Carvalho Chehab
2016-10-18 20:46 ` [PATCH v2 58/58] tuners: " Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161019081920.15b97eb7@vento.lan \
--to=mchehab@s-opensource.com \
--cc=linux-media@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=mchehab@infradead.org \
--cc=mchehab@kernel.org \
--cc=o-takashi@sakamocchi.jp \
--cc=stefanr@s5r6.in-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.