From mboxrd@z Thu Jan  1 00:00:00 1970
From: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Subject: Re: [PATCH v2] net/mlx5: fix init on secondary process
Date: Wed, 19 Oct 2016 12:05:48 +0200
Message-ID: <20161019100548.GD5733@6wind.com>
References: <1475072658-29534-1-git-send-email-ogournet@corp.free.fr>
 <1476708993-62820-1-git-send-email-ogournet@corp.free.fr>
 <bba8c669-2a19-575f-41c0-25b70128cc96@intel.com>
 <20161017141859.GB5733@6wind.com>
 <20161019093147.GD27816@bricha3-MOBL3.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Ferruh Yigit <ferruh.yigit@intel.com>,
 Olivier Gournet <ogournet@corp.free.fr>, dev@dpdk.org,
 Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f43.google.com (mail-wm0-f43.google.com [74.125.82.43])
 by dpdk.org (Postfix) with ESMTP id 1A7D16936
 for <dev@dpdk.org>; Wed, 19 Oct 2016 12:05:56 +0200 (CEST)
Received: by mail-wm0-f43.google.com with SMTP id f193so49975552wmg.1
 for <dev@dpdk.org>; Wed, 19 Oct 2016 03:05:56 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20161019093147.GD27816@bricha3-MOBL3.ger.corp.intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Wed, Oct 19, 2016 at 10:31:48AM +0100, Bruce Richardson wrote:
> On Mon, Oct 17, 2016 at 04:18:59PM +0200, Adrien Mazarguil wrote:
> > On Mon, Oct 17, 2016 at 02:52:39PM +0100, Ferruh Yigit wrote:
> > > Hi Adrien,
> > > 
> > > On 10/17/2016 1:56 PM, Olivier Gournet wrote:
> > > > Fixes: 1d88ba171942 ("net/mlx5: refactor Tx data path")
> > > > Fixes: 21c8bb4928c9 ("net/mlx5: split Tx queue structure")
> > > > 
> > > > Signed-off-by: Olivier Gournet <ogournet@corp.free.fr>
> > > 
> > > According your comment on previous version of it, I think you have your
> > > Ack on this patch, but can you please confirm?
> > 
> > Yes it's fine, thanks.
> > 
> > Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
> > 
> > -- 
> While this patch is acked, I'd still like a bit of detail in the commit
> message describing what the problem is and how the patch fixes it. The
> Chuck Norris approach of trying to stare down the code until it tells
> me just isn't working for me today! :-)
> 
> Adrien or Olivier, if you can supply a brief description of what this
> patch is doing and why I'll add it to the commit log on apply.

*cough* this patch restores the original behavior of not causing a secondary
process to segfault during init.

Seriously, one needs to look at mlx5_secondary_data_setup() in both commits
to really understand what happened, my suggestion for a commit log:

The changes introduced by these commits made secondaries attempt to
reinitialize the TX queue structures of the primary instead of their own,
for which they also do not allocate enough memory, leading to crashes.

-- 
Adrien Mazarguil
6WIND