From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Wed, 19 Oct 2016 15:19:00 +0200 From: Christoph Hellwig To: Bart Van Assche Subject: Re: [PATCH v3 02/11] blk-mq: Introduce blk_mq_hctx_stopped() Message-ID: <20161019131900.GB6323@lst.de> References: MIME-Version: 1.0 In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Keith Busch , Ming Lin , James Bottomley , "Martin K. Petersen" , Mike Snitzer , "linux-rdma@vger.kernel.org" , "linux-nvme@lists.infradead.org" , Jens Axboe , Doug Ledford , "linux-block@vger.kernel.org" , "linux-scsi@vger.kernel.org" , Laurence Oberman , Christoph Hellwig Content-Type: text/plain; charset="us-ascii" Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+axboe=kernel.dk@lists.infradead.org List-ID: On Tue, Oct 18, 2016 at 02:49:09PM -0700, Bart Van Assche wrote: > Multiple functions test the BLK_MQ_S_STOPPED bit so introduce > a helper function that performs this test. Looks sensible. Any reason to have it in the public blk-mq.h instead of the private one, though? I see that dm is using it with this patch, but that usage should go away once your full series is merged, right? _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme From mboxrd@z Thu Jan 1 00:00:00 1970 From: hch@lst.de (Christoph Hellwig) Date: Wed, 19 Oct 2016 15:19:00 +0200 Subject: [PATCH v3 02/11] blk-mq: Introduce blk_mq_hctx_stopped() In-Reply-To: References: Message-ID: <20161019131900.GB6323@lst.de> On Tue, Oct 18, 2016@02:49:09PM -0700, Bart Van Assche wrote: > Multiple functions test the BLK_MQ_S_STOPPED bit so introduce > a helper function that performs this test. Looks sensible. Any reason to have it in the public blk-mq.h instead of the private one, though? I see that dm is using it with this patch, but that usage should go away once your full series is merged, right? From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH v3 02/11] blk-mq: Introduce blk_mq_hctx_stopped() Date: Wed, 19 Oct 2016 15:19:00 +0200 Message-ID: <20161019131900.GB6323@lst.de> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-block-owner@vger.kernel.org To: Bart Van Assche Cc: Jens Axboe , Christoph Hellwig , James Bottomley , "Martin K. Petersen" , Mike Snitzer , Doug Ledford , Keith Busch , Ming Lin , Laurence Oberman , "linux-block@vger.kernel.org" , "linux-scsi@vger.kernel.org" , "linux-rdma@vger.kernel.org" , "linux-nvme@lists.infradead.org" List-Id: linux-rdma@vger.kernel.org On Tue, Oct 18, 2016 at 02:49:09PM -0700, Bart Van Assche wrote: > Multiple functions test the BLK_MQ_S_STOPPED bit so introduce > a helper function that performs this test. Looks sensible. Any reason to have it in the public blk-mq.h instead of the private one, though? I see that dm is using it with this patch, but that usage should go away once your full series is merged, right?