From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Wed, 19 Oct 2016 15:30:50 +0200 From: Christoph Hellwig To: Bart Van Assche Subject: Re: [PATCH v3 07/11] dm: Fix a race condition related to stopping and starting queues Message-ID: <20161019133050.GG6323@lst.de> References: <1e89a7d7-5cae-40b1-ce31-09d630e6f33d@sandisk.com> MIME-Version: 1.0 In-Reply-To: <1e89a7d7-5cae-40b1-ce31-09d630e6f33d@sandisk.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Keith Busch , Ming Lin , James Bottomley , "Martin K. Petersen" , Mike Snitzer , "linux-rdma@vger.kernel.org" , "linux-nvme@lists.infradead.org" , Jens Axboe , Doug Ledford , "linux-block@vger.kernel.org" , "linux-scsi@vger.kernel.org" , Laurence Oberman , Christoph Hellwig Content-Type: text/plain; charset="us-ascii" Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+axboe=kernel.dk@lists.infradead.org List-ID: Looks good: Reviewed-by: Christoph Hellwig FYI, I wonder how many of the blk_mq_stop_hw_queues do not need the quiesce call. In the long run it might be better to have blk_mq_stop_hw_queues to stop an quiesce, and have a __blk_mq_stop_hw_queues variant to just stop. _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme From mboxrd@z Thu Jan 1 00:00:00 1970 From: hch@lst.de (Christoph Hellwig) Date: Wed, 19 Oct 2016 15:30:50 +0200 Subject: [PATCH v3 07/11] dm: Fix a race condition related to stopping and starting queues In-Reply-To: <1e89a7d7-5cae-40b1-ce31-09d630e6f33d@sandisk.com> References: <1e89a7d7-5cae-40b1-ce31-09d630e6f33d@sandisk.com> Message-ID: <20161019133050.GG6323@lst.de> Looks good: Reviewed-by: Christoph Hellwig FYI, I wonder how many of the blk_mq_stop_hw_queues do not need the quiesce call. In the long run it might be better to have blk_mq_stop_hw_queues to stop an quiesce, and have a __blk_mq_stop_hw_queues variant to just stop. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH v3 07/11] dm: Fix a race condition related to stopping and starting queues Date: Wed, 19 Oct 2016 15:30:50 +0200 Message-ID: <20161019133050.GG6323@lst.de> References: <1e89a7d7-5cae-40b1-ce31-09d630e6f33d@sandisk.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1e89a7d7-5cae-40b1-ce31-09d630e6f33d@sandisk.com> Sender: linux-scsi-owner@vger.kernel.org To: Bart Van Assche Cc: Jens Axboe , Christoph Hellwig , James Bottomley , "Martin K. Petersen" , Mike Snitzer , Doug Ledford , Keith Busch , Ming Lin , Laurence Oberman , "linux-block@vger.kernel.org" , "linux-scsi@vger.kernel.org" , "linux-rdma@vger.kernel.org" , "linux-nvme@lists.infradead.org" List-Id: linux-rdma@vger.kernel.org Looks good: Reviewed-by: Christoph Hellwig FYI, I wonder how many of the blk_mq_stop_hw_queues do not need the quiesce call. In the long run it might be better to have blk_mq_stop_hw_queues to stop an quiesce, and have a __blk_mq_stop_hw_queues variant to just stop.