From: Vinod Koul <vinod.koul@intel.com>
To: Colin King <colin.king@canonical.com>
Cc: Dan Williams <dan.j.williams@intel.com>,
Dave Jiang <dave.jiang@intel.com>,
Lars-Peter Clausen <lars@metafoo.de>,
dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dmaengine: ioatdma: loop for number elements in array chanerr_str
Date: Wed, 19 Oct 2016 20:17:31 +0530 [thread overview]
Message-ID: <20161019144730.GP2467@localhost> (raw)
In-Reply-To: <20161016122547.11478-1-colin.king@canonical.com>
On Sun, Oct 16, 2016 at 01:25:47PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Just iterate over the number of elements in array chanerr_str rather
> than for all 32 bits. This removes the need for a NULL chanerr_str[i]
> check which could possibly overrun if the upper bits (28..31) of
> chanerr are set and 27th bit in chanerr is zero. This simplifies the
> code by removing an if statement and a break.
Applied, thanks
--
~Vinod
prev parent reply other threads:[~2016-10-19 14:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-16 12:25 [PATCH] dmaengine: ioatdma: loop for number elements in array chanerr_str Colin King
2016-10-19 14:47 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161019144730.GP2467@localhost \
--to=vinod.koul@intel.com \
--cc=colin.king@canonical.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=lars@metafoo.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.