From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: "Winkler, Tomas" <tomas.winkler@intel.com>
Cc: "tpmdd-devel@lists.sourceforge.net"
<tpmdd-devel@lists.sourceforge.net>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [tpmdd-devel] [PATCH] tpm, tpm_crb: remove redundant CRB_FL_CRB_START flag
Date: Wed, 19 Oct 2016 19:09:28 +0300 [thread overview]
Message-ID: <20161019160928.n5fswy25t2ppdh73@intel.com> (raw)
In-Reply-To: <5B8DA87D05A7694D9FA63FD143655C1B542FF8FC@hasmsx108.ger.corp.intel.com>
On Wed, Oct 19, 2016 at 10:28:29AM +0000, Winkler, Tomas wrote:
>
>
> >
> > On Mon, Oct 17, 2016 at 11:42:24PM +0300, Jarkko Sakkinen wrote:
> > > Because all the existing hardware have HID MSFT0101 we end up always
> > > setting CRB_FL_CRB_START flag as a workaround for 4th Gen Core CPUs.
> > > Even if ACPI start is used, the driver will always issue also CRB start.
>
> Do you have some more historical data about this fix, I was wondering
> about this quirk before, when restructuring the start method parsing.
> The description is ' in practice seems to require both' sounds not
> certain about the root cause of this.
I have a 4th Gen Core NUC where I experienced this issue. It reported
requiring only ACPI start but actually required ACPI + CRB start. The
comment could have been better.
/Jarkko
next prev parent reply other threads:[~2016-10-19 16:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-17 20:42 [PATCH] tpm, tpm_crb: remove redundant CRB_FL_CRB_START flag Jarkko Sakkinen
2016-10-17 20:42 ` Jarkko Sakkinen
2016-10-17 22:51 ` Jarkko Sakkinen
[not found] ` <20161017225113.qnghq5vroxlmsurc-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-10-19 10:28 ` Winkler, Tomas
2016-10-19 10:28 ` [tpmdd-devel] " Winkler, Tomas
2016-10-19 16:09 ` Jarkko Sakkinen [this message]
[not found] ` <20161019160928.n5fswy25t2ppdh73-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-10-20 13:59 ` Jarkko Sakkinen
2016-10-20 13:59 ` [tpmdd-devel] " Jarkko Sakkinen
2016-10-20 14:00 ` Jarkko Sakkinen
[not found] ` <20161020140011.s5mu3atjjwnwqda4-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-10-20 20:24 ` Jason Gunthorpe
2016-10-20 20:24 ` [tpmdd-devel] " Jason Gunthorpe
2016-10-21 15:11 ` Jarkko Sakkinen
2016-10-25 20:31 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161019160928.n5fswy25t2ppdh73@intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tomas.winkler@intel.com \
--cc=tpmdd-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.