From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: New providers in rdma-core Date: Wed, 19 Oct 2016 11:59:26 -0600 Message-ID: <20161019175926.GD29879@obsidianresearch.com> References: <20161019163913.GA30843@infradead.org> <6b57d79c-dbd3-cd9b-061e-27a3d3968845@vmware.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <6b57d79c-dbd3-cd9b-061e-27a3d3968845-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Adit Ranadive Cc: Christoph Hellwig , Leon Romanovsky , "Amrani, Ram" , Lijun Ou , Knut Omang , Doug Ledford , linux-rdma List-Id: linux-rdma@vger.kernel.org On Wed, Oct 19, 2016 at 10:28:36AM -0700, Adit Ranadive wrote: > > Requiring installed super updtodate kernel headers isn't going to > > help development. It would be good to keep a copy of the kernel > > headers in the rdma-core repo, similar to what most kernel tools > > tied to bleeding edge ABIs do. > > Thanks for the heads up. I had a few questions regarding the ABI stuff. > What happens in case of providers that arent part of the kernel as yet? > I would like to send out a pull request soonish for libpvrdma. I would > need to include the abi files in that request since cmake would fail. Follow the pattern rxe is using: CHECK_INCLUDE_FILE("rdma/rdma_user_rxe.h" HAVE_RDMA_USER_RXE) RDMA_DoFixup("${HAVE_RDMA_USER_RXE}" "rdma/rdma_user_rxe.h") Which uses the compat header file in buildlib/fixup-include/rdma-rdma_user_rxe.h, which must be a byte-for-byte copy of the kernel header. > Or do you want me to wait till Doug adds the PVRDMA driver to the tree? FWIW, we can't take a rdma-core provider until the kernel side is accepted, but you can certainly start the process now and get it to an OK state. Doug will be able to take both parts simultaneously. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html