From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933409AbcJSScY (ORCPT ); Wed, 19 Oct 2016 14:32:24 -0400 Received: from one.firstfloor.org ([193.170.194.197]:50000 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932385AbcJSScW (ORCPT ); Wed, 19 Oct 2016 14:32:22 -0400 Date: Wed, 19 Oct 2016 11:32:18 -0700 From: Andi Kleen To: Arnaldo Carvalho de Melo Cc: Andi Kleen , jolsa@kernel.org, linux-kernel@vger.kernel.org, mingo@kernel.org, Andi Kleen Subject: Re: [PATCH 2/2] perf, tools, list: Support matching by topic Message-ID: <20161019183218.GU26852@two.firstfloor.org> References: <1476899402-31460-1-git-send-email-andi@firstfloor.org> <1476899402-31460-2-git-send-email-andi@firstfloor.org> <20161019181315.GH25522@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161019181315.GH25522@kernel.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > diff --git a/tools/perf/builtin-list.c b/tools/perf/builtin-list.c > > index 1095a6dada66..c00b0eb343c0 100644 > > --- a/tools/perf/builtin-list.c > > +++ b/tools/perf/builtin-list.c > > @@ -67,9 +67,11 @@ int cmd_list(int argc, const char **argv, const char *prefix __maybe_unused) > > print_symbol_events(NULL, PERF_TYPE_SOFTWARE, > > event_symbols_sw, PERF_COUNT_SW_MAX, raw_dump); > > else if (strcmp(argv[i], "cache") == 0 || > > - strcmp(argv[i], "hwcache") == 0) > > + strcmp(argv[i], "hwcache") == 0) { > > This is changing existing behaviour, please remove it. A separate patch > could either make it show both hwcache events and vendor cache events, That's what the patch does: "show both hwcache and vendor cache events" which is a reasonable default. I can split it into a separate patch if makes you feel better. > > > print_hwcache_events(NULL, raw_dump); > > - else if (strcmp(argv[i], "pmu") == 0) > > + print_pmu_events(argv[i], raw_dump, !desc_flag, > > + long_desc_flag, true); > > + } else if (strcmp(argv[i], "pmu") == 0) > > print_pmu_events(NULL, raw_dump, !desc_flag, > > long_desc_flag, false); > > What is this here? Only adding a } but diff displays it in a weird way. -Andi