From: Mauro Carvalho Chehab <mchehab@s-opensource.com>
To: Jean-Baptiste Abbadie <jb@abbadie.fr>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-media@vger.kernel.org
Subject: Re: [PATCH 2/3] Staging: media: radio-bcm2048: Fix indentation
Date: Wed, 19 Oct 2016 19:09:38 -0200 [thread overview]
Message-ID: <20161019190938.617ad346@vento.lan> (raw)
In-Reply-To: <20161019204714.11645-3-jb@abbadie.fr>
Em Wed, 19 Oct 2016 22:47:13 +0200
Jean-Baptiste Abbadie <jb@abbadie.fr> escreveu:
> Align multiple lines statement with parentheses
Looks OK to me. Greg, do you want to pick it on your tree or do you
prefer if I pick myself?
If you prefer to pick it:
Acked-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
>
> Signed-off-by: Jean-Baptiste Abbadie <jb@abbadie.fr>
> ---
> drivers/staging/media/bcm2048/radio-bcm2048.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c b/drivers/staging/media/bcm2048/radio-bcm2048.c
> index 188d045d44ad..f66bea631e8e 100644
> --- a/drivers/staging/media/bcm2048/radio-bcm2048.c
> +++ b/drivers/staging/media/bcm2048/radio-bcm2048.c
> @@ -997,7 +997,7 @@ static int bcm2048_set_fm_search_tune_mode(struct bcm2048_device *bdev,
> timeout = BCM2048_AUTO_SEARCH_TIMEOUT;
>
> if (!wait_for_completion_timeout(&bdev->compl,
> - msecs_to_jiffies(timeout)))
> + msecs_to_jiffies(timeout)))
> dev_err(&bdev->client->dev, "IRQ timeout.\n");
>
> if (value)
> @@ -2202,7 +2202,7 @@ static ssize_t bcm2048_fops_read(struct file *file, char __user *buf,
> }
> /* interruptible_sleep_on(&bdev->read_queue); */
> if (wait_event_interruptible(bdev->read_queue,
> - bdev->rds_data_available) < 0) {
> + bdev->rds_data_available) < 0) {
> retval = -EINTR;
> goto done;
> }
Thanks,
Mauro
next prev parent reply other threads:[~2016-10-19 21:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-19 20:47 [PATCH 0/3] media: radio-bcm2048: multiple small cleanups Jean-Baptiste Abbadie
2016-10-19 20:47 ` [PATCH 1/3] Staging: media: radio-bcm2048: Fix symbolic permissions Jean-Baptiste Abbadie
2016-10-19 21:06 ` Mauro Carvalho Chehab
2016-10-19 20:47 ` [PATCH 2/3] Staging: media: radio-bcm2048: Fix indentation Jean-Baptiste Abbadie
2016-10-19 21:09 ` Mauro Carvalho Chehab [this message]
2016-10-19 20:47 ` [PATCH 3/3] Staging: media: radio-bcm2048: Remove FSF address from GPL notice Jean-Baptiste Abbadie
2016-10-19 21:08 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161019190938.617ad346@vento.lan \
--to=mchehab@s-opensource.com \
--cc=gregkh@linuxfoundation.org \
--cc=jb@abbadie.fr \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.