From: "Pali Rohár" <pali.rohar@gmail.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Darren Hart <dvhart@infradead.org>,
Matthew Garrett <mjg59@srcf.ucam.org>,
Richard Purdie <rpurdie@rpsys.net>,
Jacek Anaszewski <j.anaszewski@samsung.com>,
platform-driver-x86@vger.kernel.org, linux-leds@vger.kernel.org
Subject: Re: [PATCH 2/2] platform: x86: dell-*: Call led_notify_brightness_change on kbd brightness change
Date: Thu, 20 Oct 2016 09:48:43 +0200 [thread overview]
Message-ID: <20161020074843.GI1689@pali> (raw)
In-Reply-To: <10c3baa9-db2f-3cf2-d924-70a77243e7f8@redhat.com>
On Wednesday 19 October 2016 18:09:27 Hans de Goede wrote:
> I agree that this is not pretty, but I could not come up with a
> simple other solution. If you've any suggestions on how you want
> to see this implemented instead I can give that a try.
I was thinking about exporting some dell_wmi_notifier_register and
unregister functions (based on atomic_notifier_chain_register) from
dell-wmi. And dell-laptop could use it. Something similar is already
implemented in dell-rbtn+dell-latop, but still I'm consider it as hack.
This one in dell-wmi could be easier as dell-rbtn because dell-wmi is
monolitic. dell-wmi could be loaded only on systems which support it, so
at that register call (from dell-laptop) you already know if you receive
events or not.
--
Pali Rohár
pali.rohar@gmail.com
next prev parent reply other threads:[~2016-10-20 7:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-19 13:33 [PATCH 0/2] Add led_notify_brightness_change led-core function and use in dell-wmi driver Hans de Goede
2016-10-19 13:33 ` [PATCH 1/2] leds: core: Add led_notify_brightness_change helper function Hans de Goede
2016-10-19 13:59 ` Pali Rohár
2016-10-19 16:07 ` Hans de Goede
2016-10-20 6:42 ` Jacek Anaszewski
2016-10-20 8:41 ` Hans de Goede
2016-10-20 9:15 ` Jacek Anaszewski
2016-10-20 10:02 ` Hans de Goede
2016-10-20 20:31 ` Jacek Anaszewski
2016-10-20 7:40 ` Pali Rohár
2016-10-19 13:33 ` [PATCH 2/2] platform: x86: dell-*: Call led_notify_brightness_change on kbd brightness change Hans de Goede
2016-10-19 14:06 ` Pali Rohár
2016-10-19 16:09 ` Hans de Goede
2016-10-20 7:48 ` Pali Rohár [this message]
2016-10-20 8:42 ` Hans de Goede
2016-10-19 14:10 ` [PATCH 0/2] Add led_notify_brightness_change led-core function and use in dell-wmi driver Pali Rohár
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161020074843.GI1689@pali \
--to=pali.rohar@gmail.com \
--cc=dvhart@infradead.org \
--cc=hdegoede@redhat.com \
--cc=j.anaszewski@samsung.com \
--cc=linux-leds@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.