From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfram Sang Subject: Re: [PATCH v2] drm/bridge: adv7511: Remove unused code blocks Date: Thu, 20 Oct 2016 10:45:35 +0200 Message-ID: <20161020084535.GA1442@katana> References: <1476785398-27255-1-git-send-email-shajit@codeaurora.org> <3685503.gXBRGfjrFE@avalon> <2505713.JpW5SKnp2Y@avalon> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1046205988==" Return-path: Received: from pokefinder.org (sauhun.de [89.238.76.85]) by gabe.freedesktop.org (Postfix) with ESMTPS id C12C26EACB for ; Thu, 20 Oct 2016 09:02:00 +0000 (UTC) In-Reply-To: <2505713.JpW5SKnp2Y@avalon> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Laurent Pinchart Cc: "Sharma, Jitendra" , dri-devel@lists.freedesktop.org, Wolfram Sang List-Id: dri-devel@lists.freedesktop.org --===============1046205988== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="nFreZHaLTZJo0R7j" Content-Disposition: inline --nFreZHaLTZJo0R7j Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable > > IMO it would be better to use id->driver_data unconditionally and save a > > call to of_device_get_match_data() > > What would you suggest to move ahead? >=20 > I'd suggest using id->driver_data unconditionally, but I'd like Wolfram's= =20 > opinion on this (CC'ed). IIUC: I'd suggest to leave it as it is. There are people working on removing the quirky fallback to i2c_device_id in case of_compatible is not provided. If that gets mainline, you don't have i2c_device_id anymore with DT matching. So all binding methods should be self-contained. --nFreZHaLTZJo0R7j Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJYCIQvAAoJEBQN5MwUoCm2gG0P/AuXinI8dE/RJikrG8TbarTa s5Hu5l2PD4HocaqCZZTeS/4+R63jYuQcykdS1F06AGiyNsOczgAyKms4hxCrXvm9 rOqbwBQPVPTPERZPtS+sbI6JzSESNiaR62FklkpZHfr3e/6AmRSxH0WKhCrHqVRg wFSEPUFrMma65QDKrVCw+uaDGqRXcsPQ29POmNlfDbFbCrwEpX+J7cKBE6KgseSh AsCvs3joGqc1VoX22hpIHycFDDKgqe4qkwov2EKAszjsAKsk8W7vo8eGZ6QqvcF5 zilXuFrlU/ZbV9dCHK/6iso/ZNAar1fa8bsm/3VtYqQzJ0DnvgkBxrL5QZYtcH3e irVx9OpSyZbSNknBxQpdNCGuRHNGUzZ7O/Is5NRM2GevdwpKsfY6zPmc4Dgpaftp ed+fZitpN+lsG5pjYuDpAbIr7+Vsac7oaODGGdT7kA5BvcvMy1vvNAOgTk6toqTm zfjgTKe9qRoKXunI4dE/Qxao46Wk1Ma39+aeAVHv1sfyVj2s9rcatxy52HlPEnKU Vm5L3SCjyQpjtyc7uIFnDWerGd0yxNXLwok6TSPn61tSkwj4/7jhdMstpz4rJpw3 U+TwtR6i4zoKZnpV6WZnPqqAP9bSDTHWyR6qnCQd2idq4WAGMEzWdKqRS7ANiIrA LytaF5ShRsRUrrLRCxRx =tvpR -----END PGP SIGNATURE----- --nFreZHaLTZJo0R7j-- --===============1046205988== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============1046205988==--