From: Christoph Hellwig <hch@infradead.org>
To: "J. Bruce Fields" <bfields@fieldses.org>
Cc: Rusty Russell <rusty@rustcorp.com.au>, linux-nfs@vger.kernel.org
Subject: Re: sg_set_buf
Date: Thu, 20 Oct 2016 03:22:00 -0700 [thread overview]
Message-ID: <20161020102200.GA6628@infradead.org> (raw)
In-Reply-To: <20161018213755.GA10777@fieldses.org>
On Tue, Oct 18, 2016 at 05:37:55PM -0400, J. Bruce Fields wrote:
> The NFS code is using sg_set_buf to turn a bit of stack menory into a
> scatterlist it can pass to the crypto code. That started BUG()ing as of
> ac4e97abce9b "scatterlist: sg_set_buf() argument must be in linear
> mapping".
>
> Is that BUG() being overly strict, or is this something we should never
> have been doing in the first place?
In general we use scatterlists to pass dma addresses to hardware, so
yes, they should not point to the stack.
next prev parent reply other threads:[~2016-10-20 10:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-18 21:37 sg_set_buf J. Bruce Fields
2016-10-20 10:22 ` Christoph Hellwig [this message]
2016-10-20 13:20 ` sg_set_buf J. Bruce Fields
2016-10-20 13:31 ` sg_set_buf Christoph Hellwig
2016-10-20 21:42 ` sg_set_buf J. Bruce Fields
[not found] ` <20161020214219.GC4347-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>
2016-10-21 12:26 ` sg_set_buf Christoph Hellwig
2016-10-21 12:26 ` sg_set_buf Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161020102200.GA6628@infradead.org \
--to=hch@infradead.org \
--cc=bfields@fieldses.org \
--cc=linux-nfs@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.