From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Lee Jones <lee.jones@linaro.org>,
linux-kernel@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH v1 1/1] mfd: intel_soc_pmic_core: Use explicit name of GPIO controller
Date: Thu, 20 Oct 2016 14:13:23 +0300 [thread overview]
Message-ID: <20161020111323.GP4329@intel.com> (raw)
In-Reply-To: <20161020093613.45939-1-andriy.shevchenko@linux.intel.com>
On Thu, Oct 20, 2016 at 12:36:13PM +0300, Andy Shevchenko wrote:
> The Crystal Cove GPIO driver has its explicit name, i.e. crystal_cove_gpio.
>
> Use it explicitly to be in align with the rest of code, pretty grepping, and
> prevent potential breakage if GPIO driver file name ever changed.
>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/mfd/intel_soc_pmic_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mfd/intel_soc_pmic_core.c b/drivers/mfd/intel_soc_pmic_core.c
> index 12d6ebb4..7fd8e87 100644
> --- a/drivers/mfd/intel_soc_pmic_core.c
> +++ b/drivers/mfd/intel_soc_pmic_core.c
> @@ -34,7 +34,7 @@ static struct gpiod_lookup_table panel_gpio_table = {
> .dev_id = "0000:00:02.0",
> .table = {
> /* Panel EN/DISABLE */
> - GPIO_LOOKUP("gpio_crystalcove", 94, "panel", GPIO_ACTIVE_HIGH),
> + GPIO_LOOKUP("crystal_cove_gpio", 94, "panel", GPIO_ACTIVE_HIGH),
This looks like it would break things. The gpio_chip->label which is
used for the lookup is based on KBUILD_MODNAME and the moduled is
called gpio-crystalcove.
> { },
> },
> };
> --
> 2.9.3
--
Ville Syrjälä
Intel OTC
next prev parent reply other threads:[~2016-10-20 11:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-20 9:36 [PATCH v1 1/1] mfd: intel_soc_pmic_core: Use explicit name of GPIO controller Andy Shevchenko
2016-10-20 11:13 ` Ville Syrjälä [this message]
2016-10-20 11:45 ` Andy Shevchenko
2016-10-23 23:22 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161020111323.GP4329@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.