From: Tony Lindgren <tony@atomide.com>
To: Jeroen Hofstee <jhofstee@victronenergy.com>
Cc: netdev@vger.kernel.org, "David S . Miller" <davem@davemloft.net>,
Anant Gole <anantgole@ti.com>, Chaithrika U S <chaithrika@ti.com>,
linux-omap@vger.kernel.org
Subject: Re: [PATCH] davinci_emac: fix setting the mac from DT
Date: Thu, 20 Oct 2016 05:41:50 -0700 [thread overview]
Message-ID: <20161020124149.v47amnfbisndai4q@atomide.com> (raw)
In-Reply-To: <1476904973-13226-1-git-send-email-jhofstee@victronenergy.com>
* Jeroen Hofstee <jhofstee@victronenergy.com> [161019 12:39]:
> commit 9120bd6e9f77 ("net: davinci_emac: Get device dm816x MAC address
> using the cpsw code") sets the mac address to the one stored in the chip
> unconditionally, overwritten the one already set from the device tree.
> This patch makes sure the mac from DT is preserved.
>
> On a am3517 this address is incorrectly read as all zeros, making it
> impossible to set a valid mac address without this patch.
OK, at least I don't have better ideas for fixing this:
Acked-by: Tony Lindgren <tony@atomide.com>
next parent reply other threads:[~2016-10-20 12:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1476904973-13226-1-git-send-email-jhofstee@victronenergy.com>
2016-10-20 12:41 ` Tony Lindgren [this message]
2016-10-20 13:35 ` [PATCH] davinci_emac: fix setting the mac from DT Jeroen Hofstee
2016-10-20 13:35 ` Jeroen Hofstee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161020124149.v47amnfbisndai4q@atomide.com \
--to=tony@atomide.com \
--cc=anantgole@ti.com \
--cc=chaithrika@ti.com \
--cc=davem@davemloft.net \
--cc=jhofstee@victronenergy.com \
--cc=linux-omap@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.