All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Radim Krčmář" <rkrcmar@redhat.com>
To: James Hogan <james.hogan@imgtec.com>
Cc: linux-mips@linux-mips.org, Paolo Bonzini <pbonzini@redhat.com>,
	Ralf Baechle <ralf@linux-mips.org>,
	kvm@vger.kernel.org
Subject: Re: [PATCH] KVM: MIPS: Add missing uaccess.h include
Date: Thu, 20 Oct 2016 15:10:54 +0200	[thread overview]
Message-ID: <20161020131054.GF8573@potion> (raw)
In-Reply-To: <d852b5f35e84e60c930589eeb14a6df21ea9b1cb.1476834183.git-series.james.hogan@imgtec.com>

2016-10-19 00:45+0100, James Hogan:
> MIPS KVM uses user memory accessors but mips.c doesn't directly include
> uaccess.h, so include it now.
> 
> This wasn't too much of a problem before v4.9-rc1 as asm/module.h
> included asm/uaccess.h, however since commit 29abfbd9cbba ("mips:
> separate extable.h, switch module.h to it") this is no longer the case.
> 
> This resulted in build failures when trace points were disabled, as
> trace/define_trace.h includes trace/trace_events.h only ifdef
> TRACEPOINTS_ENABLED, which goes on to include asm/uaccess.h via a couple
> of other headers.
> 
> Fixes: 29abfbd9cbba ("mips: separate extable.h, switch module.h to it")
> Signed-off-by: James Hogan <james.hogan@imgtec.com>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: "Radim Krčmář" <rkrcmar@redhat.com>
> Cc: Ralf Baechle <ralf@linux-mips.org>
> Cc: linux-mips@linux-mips.org
> Cc: kvm@vger.kernel.org
> ---

We'd like to have this patch in 4.9-rc2 and I see it in kvm-mips/next.
Would you prefer to send a pull request?
(I can apply it directly just as well.)

Thanks.

  reply	other threads:[~2016-10-20 13:11 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-18 23:45 [PATCH] KVM: MIPS: Add missing uaccess.h include James Hogan
2016-10-18 23:45 ` James Hogan
2016-10-20 13:10 ` Radim Krčmář [this message]
2016-10-20 13:16   ` James Hogan
2016-10-20 13:16     ` James Hogan
2016-10-20 17:53     ` Radim Krčmář
2016-10-20 19:15       ` James Hogan
2016-10-20 19:15         ` James Hogan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161020131054.GF8573@potion \
    --to=rkrcmar@redhat.com \
    --cc=james.hogan@imgtec.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-mips@linux-mips.org \
    --cc=pbonzini@redhat.com \
    --cc=ralf@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.