From: Martyn Welch <martyn.welch-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>
To: Johan Hovold <johan-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Linus Walleij
<linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Alexandre Courbot
<gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Greg Kroah-Hartman
<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>,
linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Karl Palsson <karlp-PhA6lrgffZtPR4JQBCEnsQ@public.gmane.org>,
Konstantin Shkolnyy
<Konstantin.Shkolnyy-S6d6foEdJf7QT0dZR+AlfA@public.gmane.org>,
Peter Senna Tschudin
<peter.senna-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
Subject: Re: [PATCH v10 1/1] USB: serial: cp210x: Adding GPIO support for CP2105
Date: Thu, 20 Oct 2016 14:31:36 +0100 [thread overview]
Message-ID: <20161020133136.GW355@hermes.home> (raw)
In-Reply-To: <20161020084924.GN2765@localhost>
On Thu, Oct 20, 2016 at 10:49:24AM +0200, Johan Hovold wrote:
> On Thu, Oct 20, 2016 at 09:13:41AM +0100, Martyn Welch wrote:
> > + /* 2 banks of GPIO - One for the pins taken from each serial port */
> > + if (intf_num == 0) {
> > + if (mode.eci == 0)
>
> Would you mind explaining how mode is used as I asked in my comments to
> v8?
>
These are set to 0 if in "modem mode" or 1 if in "gpio mode". I will add
these as defines to make this clear.
Martyn
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-10-20 13:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-20 8:13 [PATCH v10 1/1] USB: serial: cp210x: Adding GPIO support for CP2105 Martyn Welch
[not found] ` <33cb529dad5c28a135e9e21460582c3cc4e6d4b5.1476950450.git.martyn.welch-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>
2016-10-20 8:49 ` Johan Hovold
2016-10-20 13:31 ` Martyn Welch [this message]
2016-10-25 9:34 ` Linus Walleij
[not found] ` <CACRpkdab5d71TgrTD-4U95R6MvWdFcaqRcGpPS0D8sExKi=b3g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-10-26 9:09 ` Johan Hovold
2016-10-26 11:50 ` Linus Walleij
2016-10-26 12:16 ` Johan Hovold
2016-10-31 10:17 ` Martyn Welch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161020133136.GW355@hermes.home \
--to=martyn.welch-zgy8ohtn/8ppycu2f3hruq@public.gmane.org \
--cc=Konstantin.Shkolnyy-S6d6foEdJf7QT0dZR+AlfA@public.gmane.org \
--cc=gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
--cc=johan-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=karlp-PhA6lrgffZtPR4JQBCEnsQ@public.gmane.org \
--cc=linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=peter.senna-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.