From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-owner@vger.kernel.org>
Received: from mail.linuxfoundation.org ([140.211.169.12]:54259 "EHLO
        mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S938654AbcJTOWb (ORCPT
        <rfc822;stable@vger.kernel.org>); Thu, 20 Oct 2016 10:22:31 -0400
Date: Thu, 20 Oct 2016 16:22:37 +0200
From: Greg KH <gregkh@linuxfoundation.org>
To: nicolas.iooss_linux@m4x.org, kvalo@codeaurora.org
Cc: stable@vger.kernel.org
Subject: Re: FAILED: patch "[PATCH] brcmfmac: fix pmksa->bssid usage" failed
 to apply to 4.4-stable tree
Message-ID: <20161020142237.GA17343@kroah.com>
References: <147697299513981@kroah.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <147697299513981@kroah.com>
Sender: stable-owner@vger.kernel.org
List-ID: <stable.vger.kernel.org>

On Thu, Oct 20, 2016 at 04:16:35PM +0200, gregkh@linuxfoundation.org wrote:
> 
> The patch below does not apply to the 4.4-stable tree.
> If someone wants it applied there, or to any other stable or longterm
> tree, then please email the backport, including the original git commit
> id to <stable@vger.kernel.org>.
> 
> thanks,
> 
> greg k-h
> 
> ------------------ original commit in Linus's tree ------------------
> 
> >From 7703773ef1d85b40433902a8da20167331597e4a Mon Sep 17 00:00:00 2001
> From: Nicolas Iooss <nicolas.iooss_linux@m4x.org>
> Date: Tue, 23 Aug 2016 11:37:17 +0200
> Subject: [PATCH] brcmfmac: fix pmksa->bssid usage
> 
> The struct cfg80211_pmksa defines its bssid field as:
> 
>     const u8 *bssid;
> 
> contrary to struct brcmf_pmksa, which uses:
> 
>     u8 bssid[ETH_ALEN];
> 
> Therefore in brcmf_cfg80211_del_pmksa(), &pmksa->bssid takes the address
> of this field (of type u8**), not the one of its content (which would be
> u8*).  Remove the & operator to make brcmf_dbg("%pM") and memcmp()
> behave as expected.
> 
> This bug have been found using a custom static checker (which checks the
> usage of %p... attributes at build time).  It has been introduced in
> commit 6c404f34f2bd ("brcmfmac: Cleanup pmksa cache handling code"),
> which replaced pmksa->bssid by &pmksa->bssid while refactoring the code,
> without modifying struct cfg80211_pmksa definition.
> 
> Replace &pmk[i].bssid with pmk[i].bssid too to make the code clearer,
> this change does not affect the semantic.
> 
> Fixes: 6c404f34f2bd ("brcmfmac: Cleanup pmksa cache handling code")
> Cc: stable@vger.kernel.org
> Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>

Nevermind, this wasn't for 4.4, sorry for the noise...