From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Fri, 21 Oct 2016 08:06:01 +0000 Subject: [patch] drm/i915/gvt: cleanup a type issue in submit_context() Message-Id: <20161021080601.GA28738@elgon.mountain> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Daniel Vetter Cc: dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, kernel-janitors@vger.kernel.org, Yulei Zhang , Zhi Wang submit_context() should return negative error codes and zero on success but by mistake we made it a bool. I've changed it to int. Also I made it static because this isn't referenced in any other files. This doesn't affect runtime because the return is eventually propogated to elsp_mmio_write() where it is ignored. Signed-off-by: Dan Carpenter diff --git a/drivers/gpu/drm/i915/gvt/execlist.c b/drivers/gpu/drm/i915/gvt/execlist.c index c50a3d1a5131..bc69ba1842ea 100644 --- a/drivers/gpu/drm/i915/gvt/execlist.c +++ b/drivers/gpu/drm/i915/gvt/execlist.c @@ -616,7 +616,7 @@ static int prepare_mm(struct intel_vgpu_workload *workload) (list_empty(q) ? NULL : container_of(q->prev, \ struct intel_vgpu_workload, list)) -bool submit_context(struct intel_vgpu *vgpu, int ring_id, +static int submit_context(struct intel_vgpu *vgpu, int ring_id, struct execlist_ctx_descriptor_format *desc, bool emulate_schedule_in) { From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: [patch] drm/i915/gvt: cleanup a type issue in submit_context() Date: Fri, 21 Oct 2016 11:06:01 +0300 Message-ID: <20161021080601.GA28738@elgon.mountain> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter Cc: dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, kernel-janitors@vger.kernel.org, Yulei Zhang , Zhi Wang List-Id: dri-devel@lists.freedesktop.org c3VibWl0X2NvbnRleHQoKSBzaG91bGQgcmV0dXJuIG5lZ2F0aXZlIGVycm9yIGNvZGVzIGFuZCB6 ZXJvIG9uIHN1Y2Nlc3MKYnV0IGJ5IG1pc3Rha2Ugd2UgbWFkZSBpdCBhIGJvb2wuICBJJ3ZlIGNo YW5nZWQgaXQgdG8gaW50LiAgQWxzbyBJIG1hZGUKaXQgc3RhdGljIGJlY2F1c2UgdGhpcyBpc24n dCByZWZlcmVuY2VkIGluIGFueSBvdGhlciBmaWxlcy4KClRoaXMgZG9lc24ndCBhZmZlY3QgcnVu dGltZSBiZWNhdXNlIHRoZSByZXR1cm4gaXMgZXZlbnR1YWxseSBwcm9wb2dhdGVkCnRvIGVsc3Bf bW1pb193cml0ZSgpIHdoZXJlIGl0IGlzIGlnbm9yZWQuCgpTaWduZWQtb2ZmLWJ5OiBEYW4gQ2Fy cGVudGVyIDxkYW4uY2FycGVudGVyQG9yYWNsZS5jb20+CgpkaWZmIC0tZ2l0IGEvZHJpdmVycy9n cHUvZHJtL2k5MTUvZ3Z0L2V4ZWNsaXN0LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9ndnQvZXhl Y2xpc3QuYwppbmRleCBjNTBhM2QxYTUxMzEuLmJjNjliYTE4NDJlYSAxMDA2NDQKLS0tIGEvZHJp dmVycy9ncHUvZHJtL2k5MTUvZ3Z0L2V4ZWNsaXN0LmMKKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5 MTUvZ3Z0L2V4ZWNsaXN0LmMKQEAgLTYxNiw3ICs2MTYsNyBAQCBzdGF0aWMgaW50IHByZXBhcmVf bW0oc3RydWN0IGludGVsX3ZncHVfd29ya2xvYWQgKndvcmtsb2FkKQogCShsaXN0X2VtcHR5KHEp ID8gTlVMTCA6IGNvbnRhaW5lcl9vZihxLT5wcmV2LCBcCiAJc3RydWN0IGludGVsX3ZncHVfd29y a2xvYWQsIGxpc3QpKQogCi1ib29sIHN1Ym1pdF9jb250ZXh0KHN0cnVjdCBpbnRlbF92Z3B1ICp2 Z3B1LCBpbnQgcmluZ19pZCwKK3N0YXRpYyBpbnQgc3VibWl0X2NvbnRleHQoc3RydWN0IGludGVs X3ZncHUgKnZncHUsIGludCByaW5nX2lkLAogCQlzdHJ1Y3QgZXhlY2xpc3RfY3R4X2Rlc2NyaXB0 b3JfZm9ybWF0ICpkZXNjLAogCQlib29sIGVtdWxhdGVfc2NoZWR1bGVfaW4pCiB7Cl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5n IGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVk ZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=