All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel@ffwll.ch>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v3 03/15] drm: Add support for optional per-plane rotation property
Date: Fri, 21 Oct 2016 18:23:43 +0200	[thread overview]
Message-ID: <20161021162342.GI20761@phenom.ffwll.local> (raw)
In-Reply-To: <20160927102248.GI4329@intel.com>

On Tue, Sep 27, 2016 at 01:22:48PM +0300, Ville Syrjälä wrote:
> On Tue, Sep 27, 2016 at 12:54:46PM +0300, Joonas Lahtinen wrote:
> > On ma, 2016-09-26 at 19:30 +0300, ville.syrjala@linux.intel.com wrote:
> > > diff --git a/drivers/gpu/drm/drm_blend.c b/drivers/gpu/drm/drm_blend.c
> > > 
> > > index 85172a977bf3..e52aece30900 100644
> > > --- a/drivers/gpu/drm/drm_blend.c
> > > +++ b/drivers/gpu/drm/drm_blend.c
> > 
> > Now that I'm thinking, *_zpos_* fits to drm_blend.c nicely, but not
> > sure if rotation is related to blending so much. Maybe it should be
> > like a new file drm_transform.c (or drm_plane.c to be overly generic),
> > not sure.
> 
> The next guy who moves it gets to rebase all of my ~500 branches! Or
> alternatively gets to make git smarter so it'll detect the pointless
> shuffling automagically.

My idea behind drm_blend is to cover _everything_ between the raw
framebuffer data and the final crtc picture. So scaling, rotation,
blending and anything like that.

I should probably have called it compositing, but oh well that fail is now
done.
-Daniel

> 
> > 
> > Anyway,
> > 
> > Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> > 
> > Regards, Joonas
> > -- 
> > Joonas Lahtinen
> > Open Source Technology Center
> > Intel Corporation
> 
> -- 
> Ville Syrjälä
> Intel OTC
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2016-10-21 16:23 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-26 16:30 [PATCH v2 00/16] drm: drm: Per-plane rotation etc ville.syrjala
2016-09-26 16:30 ` [PATCH v2 01/15] drm: Add drm_rotation_90_or_270() ville.syrjala
2016-09-27  9:32   ` Joonas Lahtinen
2016-09-26 16:30 ` [PATCH 02/15] drm/atomic: Reject attempts to use multiple rotation angles at once ville.syrjala
2016-09-26 16:30 ` [PATCH v3 03/15] drm: Add support for optional per-plane rotation property ville.syrjala
2016-09-27  9:54   ` [Intel-gfx] " Joonas Lahtinen
2016-09-27 10:22     ` Ville Syrjälä
2016-10-21 16:23       ` Daniel Vetter [this message]
2016-09-26 16:30 ` [PATCH v2 04/15] drm/arm: Use " ville.syrjala
2016-09-26 16:30 ` [PATCH v3 05/15] drm/atmel-hlcdc: " ville.syrjala
2016-09-26 16:30 ` [PATCH v2 06/15] drm/omap: Set rotation property initial value to BIT(DRM_ROTATE_0) insted of 0 ville.syrjala
2016-09-26 16:30 ` [PATCH v2 07/15] drm/omap: Use per-plane rotation property ville.syrjala
2016-10-06  9:59   ` Tomi Valkeinen
2016-10-06 10:30     ` Ville Syrjälä
2016-10-06 10:32       ` Tomi Valkeinen
2016-09-26 16:30 ` [PATCH v2 08/15] drm/msm/mdp5: Set rotation property initial value to BIT(DRM_ROTATE_0) insted of 0 ville.syrjala
2016-10-21 16:26   ` Daniel Vetter
2016-10-21 16:40     ` Ville Syrjälä
2016-09-26 16:30 ` [PATCH v2 09/15] drm/msm/mdp5: Use per-plane rotation property ville.syrjala
2016-09-26 16:30 ` [PATCH v2 10/15] drm/msm/mdp5: Advertize 180 degree rotation ville.syrjala
2016-09-26 16:30 ` [PATCH v3 11/15] drm/i915: Use the per-plane rotation property ville.syrjala
2016-09-27  9:58   ` Joonas Lahtinen
2016-10-21 16:28     ` [Intel-gfx] " Daniel Vetter
2016-09-26 16:30 ` [PATCH v2 12/15] drm: RIP mode_config->rotation_property ville.syrjala
2016-09-27 10:00   ` [Intel-gfx] " Joonas Lahtinen
2016-09-26 16:30 ` [PATCH v2 13/15] drm/i915: Use & instead if == to check for rotations ville.syrjala
2016-09-26 16:30 ` [PATCH v2 14/15] drm/i915: Clean up rotation DSPCNTR/DVSCNTR/etc. setup ville.syrjala
2016-09-26 16:31 ` [PATCH v2 15/15] drm/i915: Add horizontal mirroring support for CHV pipe B planes ville.syrjala
2016-09-27 10:02   ` [Intel-gfx] " Joonas Lahtinen
2016-09-26 16:40 ` [PATCH v2 00/16] drm: drm: Per-plane rotation etc Ville Syrjälä
2016-09-26 17:12 ` Rob Clark
2016-09-26 17:19 ` ✗ Fi.CI.BAT: warning for " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161021162342.GI20761@phenom.ffwll.local \
    --to=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.