Re: [Qemu-devel] [PATCH] target-i386: Print warning when mixing [+-]foo and foo=(on|off)

[no-reply@patchew.org]

Hi,

Your series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH] target-i386: Print warning when mixing [+-]foo and foo=(on|off)
Type: series
Message-id: 1477075788-26632-1-git-send-email-ehabkost@redhat.com

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
9d8f97d target-i386: Print warning when mixing [+-]foo and foo=(on|off)

=== OUTPUT BEGIN ===
Checking PATCH 1/1: target-i386: Print warning when mixing [+-]foo and foo=(on|off)...
ERROR: Error messages should not contain newlines
#35: FILE: target-i386/cpu.c:2032:
+                         "Don't mix both \"+%s\" and \"%s=%s\"\n"

ERROR: Error messages should not contain newlines
#42: FILE: target-i386/cpu.c:2039:
+                         "Don't mix both \"-%s\" and \"%s=%s\"\n"

ERROR: line over 90 characters
#84: FILE: tests/test-x86-cpuid-compat.c:114:
+    g_test_trap_assert_stderr("*Ambiguous CPU model string. Don't mix both \"-mce\" and \"mce=on\"*");

ERROR: line over 90 characters
#85: FILE: tests/test-x86-cpuid-compat.c:115:
+    g_test_trap_assert_stderr("*Ambiguous CPU model string. Don't mix both \"+cx8\" and \"cx8=off\"*");

ERROR: line over 90 characters
#94: FILE: tests/test-x86-cpuid-compat.c:123:
+    g_test_add_func("/x86/cpuid/parsing-plus-minus/subprocess", test_plus_minus_subprocess);

total: 5 errors, 0 warnings, 73 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org