From: Wei Liu <wei.liu2@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
Wei Liu <wei.liu2@citrix.com>,
Xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH] x86/emul: Correctly annotate all push/pop %sreg instructions
Date: Mon, 24 Oct 2016 10:54:42 +0100 [thread overview]
Message-ID: <20161024095442.GE3543@citrix.com> (raw)
In-Reply-To: <580DEF150200007800118DFD@prv-mh.provo.novell.com>
On Mon, Oct 24, 2016 at 03:23:01AM -0600, Jan Beulich wrote:
> >>> On 19.10.16 at 18:30, <andrew.cooper3@citrix.com> wrote:
> > c/s 373923ed9c2 "x86emul: fix pushing of selector registers" redirected
> > all push %sreg instructions into the general push path. However, this
> > ends up hitting the assertion at the head of the push path.
> >
> > Annotate All push and pop %sreg instructions as Mov, indicating that
> > they do not read the destination operand.
> >
> > Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
>
> Reviewed-by: Jan Beulich <jbeulich@suse.com>
>
> I wonder how this passed both my and osstest's testing...
>
OSSTest Cambridge instance (with rather old hardware) caught this IIRC.
I've queued this up for committing since this is needed for 4.8.
Wei.
> Jan
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> https://lists.xen.org/xen-devel
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-10-24 9:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-19 16:30 [PATCH] x86/emul: Correctly annotate all push/pop %sreg instructions Andrew Cooper
2016-10-24 9:23 ` Jan Beulich
2016-10-24 9:54 ` Wei Liu [this message]
2016-10-24 9:56 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161024095442.GE3543@citrix.com \
--to=wei.liu2@citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.