From: Wei Liu <wei.liu2@citrix.com>
To: Dario Faggioli <dario.faggioli@citrix.com>
Cc: Juergen Gross <jgross@suse.com>,
Xen-devel <xen-devel@lists.xenproject.org>,
Wei Liu <wei.liu2@citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>
Subject: Re: [PATCH] libxl: only free vcpu info list when it is allocated
Date: Mon, 24 Oct 2016 11:02:47 +0100 [thread overview]
Message-ID: <20161024100247.GB30231@citrix.com> (raw)
In-Reply-To: <1477070776.24930.145.camel@citrix.com>
On Fri, Oct 21, 2016 at 07:26:16PM +0200, Dario Faggioli wrote:
> On Fri, 2016-10-21 at 18:17 +0100, Wei Liu wrote:
> > Clang complains nr_dom_vcpus may be used uninitialized after
> > 4a6070ea9.
> >
> > The real issue is vinfo can be NULL and nr_dom_vcpus remains
> > uninitialized if previous call fails.
> >
> If it were me doing this, I'd just have initialized nr_dom_vcpus to 0.
>
> This is what I've always done when using libxl_numainfo_list_free(),
> which is similar to this (then how did I miss doing it here? Oh,
> well... :-/)
>
> And since we're initializing vinfo to NULL already, initializing
> nr_dom_vcpus as well makes things look more uniform.
>
Right. I think this is a better idea.
I will send out another version of this patch.
Wei.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
prev parent reply other threads:[~2016-10-24 10:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-21 17:17 [PATCH] libxl: only free vcpu info list when it is allocated Wei Liu
2016-10-21 17:26 ` Dario Faggioli
2016-10-24 10:02 ` Wei Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161024100247.GB30231@citrix.com \
--to=wei.liu2@citrix.com \
--cc=dario.faggioli@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jgross@suse.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.