From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Xu Subject: Re: [kvm-unit-tests PATCH 08/14] x86: pci: add pci_config_{read|write}[bw]() helpers Date: Mon, 24 Oct 2016 18:08:52 +0800 Message-ID: <20161024100852.GX15168@pxdev.xzpeter.org> References: <1476448852-30062-1-git-send-email-peterx@redhat.com> <1476448852-30062-9-git-send-email-peterx@redhat.com> <20161020124321.d2foxg3mszy2miuj@kamzik.brq.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Cc: kvm@vger.kernel.org, jan.kiszka@web.de, agordeev@redhat.com, rkrcmar@redhat.com, pbonzini@redhat.com To: Andrew Jones Return-path: Received: from mx1.redhat.com ([209.132.183.28]:33142 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751610AbcJXKIx (ORCPT ); Mon, 24 Oct 2016 06:08:53 -0400 Content-Disposition: inline In-Reply-To: <20161020124321.d2foxg3mszy2miuj@kamzik.brq.redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Thu, Oct 20, 2016 at 02:43:21PM +0200, Andrew Jones wrote: > On Fri, Oct 14, 2016 at 08:40:46PM +0800, Peter Xu wrote: > > And some cleanup on the file. > > > > Signed-off-by: Peter Xu > > --- > > lib/x86/asm/pci.h | 37 ++++++++++++++++++++++++++++++++++--- > > 1 file changed, 34 insertions(+), 3 deletions(-) > > > > diff --git a/lib/x86/asm/pci.h b/lib/x86/asm/pci.h > > index cddde41..ce970e4 100644 > > --- a/lib/x86/asm/pci.h > > +++ b/lib/x86/asm/pci.h > > @@ -9,11 +9,42 @@ > > #include "pci.h" > > #include "x86/asm/io.h" > > > > +#define PCI_HOST_CONFIG_PORT (0xcf8) > > +#define PCI_HOST_DATA_PORT (0xcfc) > > Thomas wanted to do this to, but I disagreed because CF8/CFC are > effectively the names already. > > Alex already has a patch in his series just like this one > "pci: x86: Add remaining PCI configuration space accessors" Right. Will drop this patch. I should mention it in the cover letter. Sorry! -- peterx