From: Dan Carpenter <dan.carpenter@oracle.com>
To: linux-fbdev@vger.kernel.org
Subject: Re: [PATCH] staging: sm750fb: Fix lock context error
Date: Mon, 24 Oct 2016 10:41:39 +0000 [thread overview]
Message-ID: <20161024104139.GY4469@mwanda> (raw)
In-Reply-To: <d825266ad9ed386b54656605fe1f805c576ebf42.1477226129.git.br.shurik@gmail.com>
On Sun, Oct 23, 2016 at 03:37:57PM +0300, Alex Briskin wrote:
> Sparse error fix - different lock contexts for basic block.
> Acquirement and release of spin lock was dependent on two separate
> unprotected variable evaluations. Instead the condition evaluation result
> is stored in a local boolean variable to make sure that the same context
> that called the spin_lock will evoke spin_unlock.
>
I kind of feel like this doesn't improve readability.
Sparse kind of sucks at flow analysis so I feel like working around
Sparse limitations is a waste of time.
regards,
dan carpenter
next prev parent reply other threads:[~2016-10-24 10:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-23 12:37 [PATCH] staging: sm750fb: Fix lock context error Alex Briskin
2016-10-24 10:41 ` Dan Carpenter [this message]
2016-10-24 12:12 ` br.shurik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161024104139.GY4469@mwanda \
--to=dan.carpenter@oracle.com \
--cc=linux-fbdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.