From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37118) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1byf1j-00051i-F0 for qemu-devel@nongnu.org; Mon, 24 Oct 2016 09:10:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1byf1e-00039w-EI for qemu-devel@nongnu.org; Mon, 24 Oct 2016 09:10:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38308) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1byf1e-00039U-8c for qemu-devel@nongnu.org; Mon, 24 Oct 2016 09:10:50 -0400 Date: Mon, 24 Oct 2016 11:10:47 -0200 From: Eduardo Habkost Message-ID: <20161024131047.GP5057@thinpad.lan.raisama.net> References: <20161020061301.31372-1-haozhong.zhang@intel.com> <20161020143412.5ea6b564@nial.brq.redhat.com> <20161020135522.GC5211@noname.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161020135522.GC5211@noname.redhat.com> Subject: Re: [Qemu-devel] [PATCH] hostmem-file: add a property 'notrunc' to avoid data corruption List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: Igor Mammedov , Haozhong Zhang , Xiao Guangrong , Peter Crosthwaite , qemu-devel@nongnu.org, mreitz@redhat.com, Paolo Bonzini , Richard Henderson On Thu, Oct 20, 2016 at 03:55:22PM +0200, Kevin Wolf wrote: > Am 20.10.2016 um 14:34 hat Igor Mammedov geschrieben: > > > #ifdef __linux__ > > > +static uint64_t get_file_size(const char *path, Error **errp) > > Maybe QEMU laredy has an utility to do it that could be shared, > > CCing block maintainers. > > We have quite a bit of code for determining the right size of a file > (including block devices) on different platforms and devices. See the > .bdrv_getlength implementations in raw-posix.c and raw-win32.c. > > However, none of them are made for consumption outside the block layer. There's a patch on qemu-devel archives from 2015: Subject [PATCH v7 11/35] util: introduce qemu_file_getlength() it could be reused here. -- Eduardo