All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oleg Nesterov <oleg@redhat.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: "Ni, BaoleX" <baolex.ni@intel.com>,
	"mingo@redhat.com" <mingo@redhat.com>,
	"acme@kernel.org" <acme@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"alexander.shishkin@linux.intel.com" 
	<alexander.shishkin@linux.intel.com>,
	"Liu, Chuansheng" <chuansheng.liu@intel.com>
Subject: Re: hit a KASan bug related to Perf during stress test
Date: Mon, 24 Oct 2016 15:40:13 +0200	[thread overview]
Message-ID: <20161024134012.GA20798@redhat.com> (raw)
In-Reply-To: <20161024132555.GA18410@redhat.com>

On 10/24, Oleg Nesterov wrote:
>
> -static u32 perf_event_pid(struct perf_event *event, struct task_struct *p)
> +static u32 perf_event_xxx(struct perf_event *event, struct task_struct *p,
> +			 	enum pid_type type)
>  {
> +	pid_t nr;
>  	/*
>  	 * only top level events have the pid namespace they were created in
>  	 */
>  	if (event->parent)
>  		event = event->parent;
>
> -	return task_tgid_nr_ns(p, event->ns);
> +	nr = __task_pid_nr_ns(p, type, event->ns);
> +	if (!nr && !is_idle_task(p))
> +		nr = -1;
> +	return nr;

And just in case... In any case __task_pid_nr_ns() and other similar helpers
can also return zero if "p" runs in another namespace. Say, in the parent ns.

Say, perf_event_switch_output(). What do we want to report in this case, zero
or -1 ?

Oleg.

  reply	other threads:[~2016-10-24 13:41 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <318B87A793BE164187D8851D6CE09D64371C8811@shsmsx102.ccr.corp.intel.com>
2016-10-24  9:53 ` hit a KASan bug related to Perf during stress test Peter Zijlstra
2016-10-24 11:15   ` Oleg Nesterov
2016-10-24 11:24     ` Peter Zijlstra
2016-10-24 12:02       ` Oleg Nesterov
2016-10-24 12:10         ` Oleg Nesterov
2016-10-24 12:22           ` Peter Zijlstra
2016-10-24 12:29             ` Oleg Nesterov
2016-10-24 12:38               ` Peter Zijlstra
2016-10-24 13:25                 ` Oleg Nesterov
2016-10-24 13:40                   ` Oleg Nesterov [this message]
2016-10-24 14:17                     ` Peter Zijlstra
2016-10-24 14:36                   ` Peter Zijlstra
2016-10-24 15:39                     ` Oleg Nesterov
2016-10-24 15:53                       ` Oleg Nesterov
2016-10-25  6:55                         ` Ni, BaoleX
2016-10-25  9:28                       ` Peter Zijlstra
2016-10-25 14:41                         ` Oleg Nesterov
2016-10-26  9:03                           ` Peter Zijlstra
2016-10-26 16:10                             ` Oleg Nesterov
2016-10-24 12:19         ` Peter Zijlstra
2016-10-24 11:27     ` Peter Zijlstra
2016-10-24 11:29       ` Peter Zijlstra
2016-10-24 12:04         ` Jiri Olsa
2016-10-24 12:12           ` Peter Zijlstra
2016-10-24 12:11     ` Peter Zijlstra
2016-10-24 12:21       ` Oleg Nesterov
2016-10-24 12:27         ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161024134012.GA20798@redhat.com \
    --to=oleg@redhat.com \
    --cc=acme@kernel.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=baolex.ni@intel.com \
    --cc=chuansheng.liu@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.