All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-devel@nongnu.org, berrange@redhat.com,
	qemu-block@nongnu.org, stefanha@redhat.com, mreitz@redhat.com,
	armbru@redhat.com
Subject: Re: [Qemu-devel] [PATCH 0/2] less confusing block file names
Date: Mon, 24 Oct 2016 15:47:50 +0200	[thread overview]
Message-ID: <20161024134750.GC4374@noname.redhat.com> (raw)
In-Reply-To: <1476925867-24748-1-git-send-email-eblake@redhat.com>

Am 20.10.2016 um 03:11 hat Eric Blake geschrieben:
> Based on a suggestion here:
> https://lists.gnu.org/archive/html/qemu-devel/2016-10/msg00350.html
> 
> Eric Blake (2):
>   block: Rename raw_bsd to raw.c
>   block: rename raw-{posix,win32} to file-*.c

Seems to do what it promises:
Reviewed-by: Kevin Wolf <kwolf@redhat.com>

I'd like to hear a few more opinions on whether it's a good idea, but I
don't think this should stay for too long on the list because we already
have conflicting patches.

One effect that makes me less than fully happy is that 'git log
block/raw.c' without --follow mixes the history of the renamed driver
with the history of the old, differently licensed one. On the other
hand, the removal of the old driver happened three years ago, so it's
probably unlikely that people confuse what belongs to which one and
revive old code accidentally.

Kevin

  parent reply	other threads:[~2016-10-24 13:48 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-20  1:11 [Qemu-devel] [PATCH 0/2] less confusing block file names Eric Blake
2016-10-20  1:11 ` [Qemu-devel] [PATCH 1/2] block: Rename raw_bsd to raw.c Eric Blake
2016-10-24 14:54   ` Laszlo Ersek
2016-10-20  1:11 ` [Qemu-devel] [PATCH 2/2] block: rename raw-{posix, win32} to file-*.c Eric Blake
2016-10-24 14:56   ` Laszlo Ersek
2016-10-21 20:17 ` [Qemu-devel] [Qemu-block] [PATCH 0/2] less confusing block file names John Snow
2016-10-24 13:47 ` Kevin Wolf [this message]
2016-10-24 14:44   ` [Qemu-devel] " Paolo Bonzini
2016-10-24 15:14     ` Kevin Wolf
2016-10-24 19:47       ` Eric Blake
2016-10-24 15:44   ` Eric Blake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161024134750.GC4374@noname.redhat.com \
    --to=kwolf@redhat.com \
    --cc=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=eblake@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.