All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Pali Rohár" <pali.rohar@gmail.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Darren Hart <dvhart@infradead.org>,
	Matthew Garrett <mjg59@srcf.ucam.org>,
	Richard Purdie <rpurdie@rpsys.net>,
	Jacek Anaszewski <j.anaszewski@samsung.com>,
	platform-driver-x86@vger.kernel.org, linux-leds@vger.kernel.org
Subject: Re: [PATCH v2 3/4] platform: x86: dell-*: Call led_notify_brightness_change on kbd brightness change
Date: Mon, 24 Oct 2016 16:10:41 +0200	[thread overview]
Message-ID: <20161024141041.GG12154@pali> (raw)
In-Reply-To: <ec56e728-9e50-3e47-3a9f-5f0920da19e1@redhat.com>

On Monday 24 October 2016 15:57:41 Hans de Goede wrote:
> Hmm, the 0000 table contains:
> 
>         /* Key code is followed by keyboard illumination level */
>         { KE_IGNORE, 0xe00c, { KEY_KBDILLUMTOGGLE } },
> 
> We could use the same keycode in the 0011 table for kbd brightness events and then do:
> 
> 	if (event->keycode == KEY_KBDILLUMTOGGLE)
> 		dell_smbios_kbd_backlight_brightness_changed, NULL);
> 
> I will send an updated version using this.

Yea, that is great!

-- 
Pali Rohár
pali.rohar@gmail.com

  reply	other threads:[~2016-10-24 14:10 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-23 19:46 [PATCH v2 1/4] leds: core: Add support for poll()ing the sysfs brightness attr for changes Hans de Goede
2016-10-23 19:46 ` [PATCH v2 2/4] platform: x86: dell-smbios: Add a generic dell-smbios notifier chain Hans de Goede
2016-10-24 13:31   ` Pali Rohár
2016-10-24 13:37     ` Hans de Goede
2016-10-24 13:43       ` Pali Rohár
2016-10-24 13:45         ` Hans de Goede
2016-10-27 10:32           ` Pali Rohár
2016-10-27 12:45             ` Hans de Goede
2016-10-27 12:51               ` Pali Rohár
2016-10-27 12:54                 ` Hans de Goede
2016-10-27 12:57                   ` Pali Rohár
2016-10-23 19:46 ` [PATCH v2 3/4] platform: x86: dell-*: Call led_notify_brightness_change on kbd brightness change Hans de Goede
2016-10-24 13:34   ` Pali Rohár
2016-10-24 13:43     ` Hans de Goede
2016-10-24 13:51       ` Pali Rohár
2016-10-24 13:57         ` Hans de Goede
2016-10-24 14:10           ` Pali Rohár [this message]
2016-10-23 19:46 ` [PATCH v2 4/4] platform: x86: dell-*: Simplify dell-rbtn integration with dell-laptop [untested] Hans de Goede
2016-10-24 20:43 ` [PATCH v2 1/4] leds: core: Add support for poll()ing the sysfs brightness attr for changes Jacek Anaszewski
2016-10-26 15:18   ` Hans de Goede
2016-10-27  6:58     ` Jacek Anaszewski
2016-10-27  7:33       ` Hans de Goede
2016-10-27  8:03         ` Jacek Anaszewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161024141041.GG12154@pali \
    --to=pali.rohar@gmail.com \
    --cc=dvhart@infradead.org \
    --cc=hdegoede@redhat.com \
    --cc=j.anaszewski@samsung.com \
    --cc=linux-leds@vger.kernel.org \
    --cc=mjg59@srcf.ucam.org \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=rpurdie@rpsys.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.