From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i2c/tda998x: mark symbol static where possible Date: Mon, 24 Oct 2016 16:27:45 +0200 Message-ID: <20161024142745.GQ20761@phenom.ffwll.local> References: <1477127682-3615-1-git-send-email-baoyou.xie@linaro.org> <5367505.BUI00TSeFs@wuerfel> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x243.google.com (mail-wm0-x243.google.com [IPv6:2a00:1450:400c:c09::243]) by gabe.freedesktop.org (Postfix) with ESMTPS id 812ED6E4D4 for ; Mon, 24 Oct 2016 14:27:49 +0000 (UTC) Received: by mail-wm0-x243.google.com with SMTP id d128so10103403wmf.0 for ; Mon, 24 Oct 2016 07:27:49 -0700 (PDT) Content-Disposition: inline In-Reply-To: <5367505.BUI00TSeFs@wuerfel> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Arnd Bergmann Cc: tang.qiang007@zte.com.cn, xie.baoyou@zte.com.cn, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, rmk+kernel@armlinux.org.uk, han.fei@zte.com.cn, Baoyou Xie List-Id: dri-devel@lists.freedesktop.org T24gTW9uLCBPY3QgMjQsIDIwMTYgYXQgMTI6MTQ6MTRQTSArMDIwMCwgQXJuZCBCZXJnbWFubiB3 cm90ZToKPiBPbiBTYXR1cmRheSwgT2N0b2JlciAyMiwgMjAxNiA1OjE0OjQyIFBNIENFU1QgQmFv eW91IFhpZSB3cm90ZToKPiA+IFdlIGdldCAxIHdhcm5pbmcgd2hlbiBidWlsZGluZyBrZXJuZWwg d2l0aCBXPTE6Cj4gPiBkcml2ZXJzL2dwdS9kcm0vaTJjL3RkYTk5OHhfZHJ2LmM6MTI5Mjo1OiB3 YXJuaW5nOiBubyBwcmV2aW91cyBwcm90b3R5cGUgZm9yICd0ZGE5OTh4X2F1ZGlvX2RpZ2l0YWxf bXV0ZScgWy1XbWlzc2luZy1wcm90b3R5cGVzXQo+ID4gCj4gPiBJbiBmYWN0LCB0aGlzIGZ1bmN0 aW9uIGlzIG9ubHkgdXNlZCBpbiB0aGUgZmlsZSBpbiB3aGljaCBpdCBpcwo+ID4gZGVjbGFyZWQg YW5kIGRvbid0IG5lZWQgYSBkZWNsYXJhdGlvbiwgYnV0IGNhbiBiZSBtYWRlIHN0YXRpYy4KPiA+ IFNvIHRoaXMgcGF0Y2ggbWFya3MgdGhpcyBmdW5jdGlvbiB3aXRoICdzdGF0aWMnLgo+ID4gCj4g PiBTaWduZWQtb2ZmLWJ5OiBCYW95b3UgWGllIDxiYW95b3UueGllQGxpbmFyby5vcmc+Cj4gPiAK PiAKPiBSZXZpZXdlZC1ieTogQXJuZCBCZXJnbWFubiA8YXJuZEBhcm5kYi5kZT4KCkFwcGxpZWQg dG8gZHJtLW1pc2MsIHRoYW5rcy4KLURhbmllbAotLSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBF bmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcg bGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRl c2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757536AbcJXO1w (ORCPT ); Mon, 24 Oct 2016 10:27:52 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:34016 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751147AbcJXO1t (ORCPT ); Mon, 24 Oct 2016 10:27:49 -0400 Date: Mon, 24 Oct 2016 16:27:45 +0200 From: Daniel Vetter To: Arnd Bergmann Cc: Baoyou Xie , tang.qiang007@zte.com.cn, xie.baoyou@zte.com.cn, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, rmk+kernel@armlinux.org.uk, han.fei@zte.com.cn Subject: Re: [PATCH] drm/i2c/tda998x: mark symbol static where possible Message-ID: <20161024142745.GQ20761@phenom.ffwll.local> Mail-Followup-To: Arnd Bergmann , Baoyou Xie , tang.qiang007@zte.com.cn, xie.baoyou@zte.com.cn, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, rmk+kernel@armlinux.org.uk, han.fei@zte.com.cn References: <1477127682-3615-1-git-send-email-baoyou.xie@linaro.org> <5367505.BUI00TSeFs@wuerfel> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5367505.BUI00TSeFs@wuerfel> X-Operating-System: Linux phenom 4.6.0-1-amd64 User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 24, 2016 at 12:14:14PM +0200, Arnd Bergmann wrote: > On Saturday, October 22, 2016 5:14:42 PM CEST Baoyou Xie wrote: > > We get 1 warning when building kernel with W=1: > > drivers/gpu/drm/i2c/tda998x_drv.c:1292:5: warning: no previous prototype for 'tda998x_audio_digital_mute' [-Wmissing-prototypes] > > > > In fact, this function is only used in the file in which it is > > declared and don't need a declaration, but can be made static. > > So this patch marks this function with 'static'. > > > > Signed-off-by: Baoyou Xie > > > > Reviewed-by: Arnd Bergmann Applied to drm-misc, thanks. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch