All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Trippelsdorf <markus@trippelsdorf.de>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
	Ingo Molnar <mingo@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Jiri Olsa <jolsa@kernel.org>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] perf hist browser: Fix hierarchy column counts
Date: Mon, 24 Oct 2016 19:00:40 +0200	[thread overview]
Message-ID: <20161024170040.GC302@x4> (raw)
In-Reply-To: <20161024162110.17918-1-namhyung@kernel.org>

On 2016.10.25 at 01:21 +0900, Namhyung Kim wrote:
> The perf report/top on TUI supports horizontal scrolling using LEFT and
> RIGHT keys.  But it calculate the number of columns incorrectly when
> hierarchy mode is enabled so that keep pressing RIGHT key can make the
> output disappeared.  In the hierarchy mode, all sort keys are collapsed
> into a single column, so it needs to be applied when calculating column
> numbers.

Thanks, this is much better now. 

But it doesn't scroll wide enough. In "perf top" when I press the RIGHT
key the symbols are shown on the hard left side. In "perf top --hierarchy",
when I press the RIGHT key, there are 5 empty spaces on the left hand
side that should be deleted.

-- 
Markus

  reply	other threads:[~2016-10-24 17:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-24 16:21 [PATCH] perf hist browser: Fix hierarchy column counts Namhyung Kim
2016-10-24 17:00 ` Markus Trippelsdorf [this message]
2016-10-24 19:38   ` Markus Trippelsdorf
2016-10-28 17:44 ` [tip:perf/core] " tip-bot for Namhyung Kim
2016-11-12 10:52 ` [tip:perf/urgent] " tip-bot for Namhyung Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161024170040.GC302@x4 \
    --to=markus@trippelsdorf.de \
    --cc=acme@kernel.org \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.