From: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Srinivas Kandagatla
<srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
tiwai-IBi9RG/b67k@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
kwestfie-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v6 1/5] ASoC: codecs: Add msm8916-wcd analog codec
Date: Mon, 24 Oct 2016 18:00:52 +0100 [thread overview]
Message-ID: <20161024170052.GD17252@sirena.org.uk> (raw)
In-Reply-To: <1476973249-14547-2-git-send-email-srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 724 bytes --]
On Thu, Oct 20, 2016 at 03:20:45PM +0100, Srinivas Kandagatla wrote:
> +static int pm8916_wcd_analog_parse_dt(struct device *dev,
> + struct pm8916_wcd_analog_priv *priv)
> +{
> + priv->mclk = devm_clk_get(dev, "mclk");
> + if (IS_ERR(priv->mclk)) {
> + dev_err(dev, "failed to get mclk\n");
> + return PTR_ERR(priv->mclk);
> + }
> + for (i = 0; i < ARRAY_SIZE(supply_names); i++)
> + priv->supplies[i].supply = supply_names[i];
> +
> + ret = devm_regulator_bulk_get(dev, ARRAY_SIZE(priv->supplies),
> + priv->supplies);
The above isn't parsing the DT, it's just requesting resources - how
those resources are mapped is hidden behind the clock and regulator
APIs. Please send a followup fixing this.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-10-24 17:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-20 14:20 [PATCH v6 0/5] ASoC: Add support to Qualcomm msm8916-wcd multi codec Srinivas Kandagatla
2016-10-20 14:20 ` [PATCH v6 1/5] ASoC: codecs: Add msm8916-wcd analog codec Srinivas Kandagatla
[not found] ` <1476973249-14547-2-git-send-email-srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-10-24 17:00 ` Mark Brown [this message]
2016-10-24 18:04 ` Applied "ASoC: codecs: Add msm8916-wcd analog codec" to the asoc tree Mark Brown
[not found] ` <1476973249-14547-1-git-send-email-srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-10-20 14:20 ` [PATCH v6 2/5] ASoC: codecs: Add msm8916-wcd digital codec Srinivas Kandagatla
[not found] ` <1476973249-14547-3-git-send-email-srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-10-24 18:04 ` Applied "ASoC: codecs: Add msm8916-wcd digital codec" to the asoc tree Mark Brown
2016-10-20 14:20 ` [PATCH v6 3/5] ASoC: apq8016-sbc: dt bindings: remove incorrect property Srinivas Kandagatla
2016-10-20 14:20 ` [PATCH v6 5/5] arm64: dts: apq8016-sbc: add analog audio support with multicodec Srinivas Kandagatla
2016-10-20 14:20 ` [PATCH v6 4/5] ASoC: qcom: apq8016-sbc: Add support to multi codec Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161024170052.GD17252@sirena.org.uk \
--to=broonie-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=kwestfie-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=tiwai-IBi9RG/b67k@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.