From: Greg KH <greg@kroah.com>
To: Josh Zimmerman <joshz@google.com>
Cc: Peter Huewe <peterhuewe@gmx.de>,
Marcel Selhorst <tpmdd@selhorst.net>,
Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
tpmdd-devel@lists.sourceforge.net, stable@vger.kernel.org
Subject: Re: [PATCH v2] tpm_tis: Check return values from get_burstcount.
Date: Mon, 24 Oct 2016 19:32:07 +0200 [thread overview]
Message-ID: <20161024173207.GA11533@kroah.com> (raw)
In-Reply-To: <20161024155439.GA27123@google.com>
On Mon, Oct 24, 2016 at 08:54:39AM -0700, Josh Zimmerman wrote:
> If the TPM we're connecting to uses a static burst count, it will report
> a burst count of zero throughout the response read. However, get_burstcount
> assumes that a response of zero indicates that the TPM is not ready to
> receive more data. In this case, it returns a negative error code, which
> is passed on to tpm_tis_{write,read}_bytes as a u16, causing
> them to read/write far too many bytes.
>
> This patch checks for negative return codes and bails out from recv_data
> and tpm_tis_send_data.
>
> Fixes: 1107d065fdf1
huh?
No signed off?
<formletter>
This is not the correct way to submit patches for inclusion in the
stable kernel tree. Please read Documentation/stable_kernel_rules.txt
for how to do this properly.
</formletter>
next prev parent reply other threads:[~2016-10-24 17:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-24 15:54 [PATCH v2] tpm_tis: Check return values from get_burstcount Josh Zimmerman
2016-10-24 15:54 ` Josh Zimmerman
2016-10-24 17:32 ` Greg KH [this message]
[not found] ` <20161024173207.GA11533-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2016-10-24 17:43 ` Josh Zimmerman
2016-10-24 17:43 ` Josh Zimmerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161024173207.GA11533@kroah.com \
--to=greg@kroah.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=jgunthorpe@obsidianresearch.com \
--cc=joshz@google.com \
--cc=peterhuewe@gmx.de \
--cc=stable@vger.kernel.org \
--cc=tpmdd-devel@lists.sourceforge.net \
--cc=tpmdd@selhorst.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.