diff for duplicates of <20161024221115.3632aa5c@vento.lan> diff --git a/a/1.txt b/N1/1.txt index d979d3d..7c2e2df 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -38,7 +38,8 @@ Andrey Utkin <andrey_utkin@fastmail.com> escreveu: > What about this (for both hunks)? > > - dev->isoc_ctl.urb = kzalloc(sizeof(void *)*num_bufs, GFP_KERNEL); -> + dev->isoc_ctl.urb > + kcalloc(num_bufs, sizeof(*dev->isoc_ctl.urb), GFP_KERNEL); +> + dev->isoc_ctl.urb = +> + kcalloc(num_bufs, sizeof(*dev->isoc_ctl.urb), GFP_KERNEL); That's worse :) @@ -51,7 +52,8 @@ The usual Kernel style is: instead of something like: - var foo(bar1, + var = + foo(bar1, bar2, bar3); diff --git a/a/content_digest b/N1/content_digest index ff73fa0..2dc2284 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -3,7 +3,7 @@ "ref\020161024222844.GD25320@dell-m4800.home\0" "From\0Mauro Carvalho Chehab <mchehab@s-opensource.com>\0" "Subject\0Re: [PATCH 1/3] [media] au0828-video: Use kcalloc() in au0828_init_isoc()\0" - "Date\0Tue, 25 Oct 2016 00:11:15 +0000\0" + "Date\0Mon, 24 Oct 2016 22:11:15 -0200\0" "To\0Andrey Utkin <andrey_utkin@fastmail.com>\0" "Cc\0SF Markus Elfring <elfring@users.sourceforge.net>" linux-media@vger.kernel.org @@ -57,7 +57,8 @@ "> What about this (for both hunks)?\n" "> \n" "> -\tdev->isoc_ctl.urb = kzalloc(sizeof(void *)*num_bufs, GFP_KERNEL);\n" - "> +\tdev->isoc_ctl.urb > +\t\tkcalloc(num_bufs, sizeof(*dev->isoc_ctl.urb), GFP_KERNEL);\n" + "> +\tdev->isoc_ctl.urb =\n" + "> +\t\tkcalloc(num_bufs, sizeof(*dev->isoc_ctl.urb), GFP_KERNEL);\n" "\n" "\n" "That's worse :)\n" @@ -70,7 +71,8 @@ "\n" "instead of something like:\n" "\n" - "\t\tvar \t\t foo(bar1,\n" + "\t\tvar =\n" + "\t\t foo(bar1,\n" "\t\t\tbar2,\n" "\t\t\tbar3);\n" "\n" @@ -84,4 +86,4 @@ "Thanks,\n" Mauro -d3eea003fd1ef1924ed7d6b7753df08337105ce6a107d93699f7e5a04ec2958a +e62e633933fc80c42e3be8e2ac3d6495aff8eeb1cc2b082c69043ae45b31f1c5
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.