From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Dmitry Tunin <hanipouspilot@gmail.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
Mathias Gottschlag <mgottschlag@gmail.com>
Subject: Re: [PATCH] Input: psmouse - cleanup Focaltech code
Date: Mon, 24 Oct 2016 16:35:50 -0700 [thread overview]
Message-ID: <20161024233550.GA9026@dtor-ws> (raw)
In-Reply-To: <1475923136-6046-1-git-send-email-hanipouspilot@gmail.com>
On Sat, Oct 08, 2016 at 01:38:56PM +0300, Dmitry Tunin wrote:
> psmouse->name "Focaltech Touchpad" is an overkill. In xinput it is too long as
> "FocaltechPS/2 Focaltech Focaltech Touchpad"
>
> In focaltech_report_state() pointer to psmouse->dev is already stored as *dev
>
> Signed-off-by: Dmitry Tunin <hanipouspilot@gmail.com>
Applied, thank you.
> ---
> drivers/input/mouse/focaltech.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/input/mouse/focaltech.c b/drivers/input/mouse/focaltech.c
> index c8c6a8c..49a56f655 100644
> --- a/drivers/input/mouse/focaltech.c
> +++ b/drivers/input/mouse/focaltech.c
> @@ -43,7 +43,7 @@ int focaltech_detect(struct psmouse *psmouse, bool set_properties)
>
> if (set_properties) {
> psmouse->vendor = "FocalTech";
> - psmouse->name = "FocalTech Touchpad";
> + psmouse->name = "Touchpad";
> }
>
> return 0;
> @@ -146,8 +146,8 @@ static void focaltech_report_state(struct psmouse *psmouse)
> }
> input_mt_report_pointer_emulation(dev, true);
>
> - input_report_key(psmouse->dev, BTN_LEFT, state->pressed);
> - input_sync(psmouse->dev);
> + input_report_key(dev, BTN_LEFT, state->pressed);
> + input_sync(dev);
> }
>
> static void focaltech_process_touch_packet(struct psmouse *psmouse,
> --
> 2.7.4
>
--
Dmitry
prev parent reply other threads:[~2016-10-24 23:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-08 10:38 [PATCH] Input: psmouse - cleanup Focaltech code Dmitry Tunin
2016-10-17 17:27 ` Mathias Gottschlag
2016-10-17 17:33 ` Dmitry Tunin
2016-10-24 23:35 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161024233550.GA9026@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=hanipouspilot@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mgottschlag@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.