From: Lee Jones <lee.jones@linaro.org>
To: Eric Jeong <eric.jeong.opensource@diasemi.com>
Cc: Alexandre Courbot <gnurou@gmail.com>,
DEVICETREE <devicetree@vger.kernel.org>,
LINUX-GPIO <linux-gpio@vger.kernel.org>,
LINUX-KERNEL <linux-kernel@vger.kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>,
Mark Brown <broonie@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Rob Herring <robh+dt@kernel.org>,
Support Opensource <support.opensource@diasemi.com>
Subject: Re: [PATCH V1] mfd: pv88080: Expand driver for GPIO function support.
Date: Tue, 25 Oct 2016 07:40:40 +0100 [thread overview]
Message-ID: <20161025064040.GE8574@dell> (raw)
In-Reply-To: <20161025014148.7DF655FA17@krsrvapps-01.diasemi.com>
On Tue, 25 Oct 2016, Eric Jeong wrote:
>
> From: Eric Jeong <eric.jeong.opensource@diasemi.com>
>
> This patch adds support for the PV88080 PMIC.
>
> This pathch is done as part of the existing PV88080 regulator driver
> by expanding the driver for GPIO function support.
>
> The MFD core driver provides communication through the I2C interface.
> and contains the following components:
>
> - Regulators
> - Configurable GPIOs
>
> Kconfig and Makefile are updated to reflect support for PV88080 PMIC.
>
> Signed-off-by: Eric Jeong <eric.jeong.opensource@diasemi.com>
>
> ---
> This patch applies against linux-next and next-20161024
>
> Hi,
>
> This change is made as a single patch. Because, to ensure that
> kernel builds and runs properly after this patch.
>
> The regulator device driver for PV88080 IC is submitted to Linux kernel.
> And now, GPIO function is required. In order to add GPIO driver,
> MFD driver is also required.
>
> Changes
> - Add MFD driver.
> - Add GPIO driver.
> - Update regulator driver to reflect the support.
> - Delete pv88080-regulator.h file.
> - Move binding document to mfd directory.
>
> Regards,
> Eric Jeong, Dialog Semiconductor Ltd.
>
>
> Documentation/devicetree/bindings/mfd/pv88080.txt | 63 +++++
> .../devicetree/bindings/regulator/pv88080.txt | 62 -----
> drivers/gpio/Kconfig | 11 +
> drivers/gpio/Makefile | 1 +
> drivers/gpio/gpio-pv88080.c | 195 ++++++++++++++
> drivers/mfd/Kconfig | 12 +
> drivers/mfd/Makefile | 2 +
> drivers/mfd/pv88080-core.c | 270 ++++++++++++++++++++
> drivers/mfd/pv88080-i2c.c | 99 +++++++
> drivers/regulator/Kconfig | 5 +-
> drivers/regulator/pv88080-regulator.c | 202 ++++++---------
> drivers/regulator/pv88080-regulator.h | 118 ---------
> include/linux/mfd/pv88080.h | 236 +++++++++++++++++
> 13 files changed, 970 insertions(+), 306 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/mfd/pv88080.txt
> delete mode 100644 Documentation/devicetree/bindings/regulator/pv88080.txt
> create mode 100644 drivers/gpio/gpio-pv88080.c
> create mode 100644 drivers/mfd/pv88080-core.c
> create mode 100644 drivers/mfd/pv88080-i2c.c
> delete mode 100644 drivers/regulator/pv88080-regulator.h
> create mode 100644 include/linux/mfd/pv88080.h
You're going to need to split this patch up as much as possible.
No one is going to want to review a 1200 line patch.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2016-10-25 6:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-25 1:37 [PATCH V1] mfd: pv88080: Expand driver for GPIO function support Eric Jeong
2016-10-25 6:40 ` Lee Jones [this message]
2016-10-25 7:11 ` Eric Hyeung Dong Jeong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161025064040.GE8574@dell \
--to=lee.jones@linaro.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=eric.jeong.opensource@diasemi.com \
--cc=gnurou@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=support.opensource@diasemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.