From: Greg KH <gregkh@linuxfoundation.org>
To: Stuart Yoder <stuart.yoder@nxp.com>
Cc: german.rivera@nxp.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, agraf@suse.de, arnd@arndb.de,
leoyang.li@nxp.com
Subject: Re: [PATCH 11/14] staging: fsl-mc: message cleanup
Date: Tue, 25 Oct 2016 09:47:46 +0200 [thread overview]
Message-ID: <20161025074746.GC22581@kroah.com> (raw)
In-Reply-To: <1476729819-10219-1-git-send-email-stuart.yoder@nxp.com>
On Mon, Oct 17, 2016 at 01:43:39PM -0500, Stuart Yoder wrote:
> Cleanup and clarify messages
> -use "fsl-mc" prefix for all messages that don't come from dev_*
> functions
Nope, please use the proper pr_fmt() #define at the top of the file,
that way you don't have to put the string into all pr_* calls.
> -remove unnecessary verbosity to make things clearer
> -use explicit __func__ arguments to clarify some error messages
> -improve misc wording for clarity
That's alot of different things. Again, if you have to list the
different things you do in a patch, that means you should break it up
into smaller ones. Yes, this is a "tiny" patch, but I can't take it
because of the above problem, while if you had broken it up into smaller
ones, I could have taken all but the pr_* changes :(
thanks,
greg k-h
prev parent reply other threads:[~2016-10-25 7:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-17 18:43 [PATCH 11/14] staging: fsl-mc: message cleanup Stuart Yoder
2016-10-25 7:47 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161025074746.GC22581@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=agraf@suse.de \
--cc=arnd@arndb.de \
--cc=devel@driverdev.osuosl.org \
--cc=german.rivera@nxp.com \
--cc=leoyang.li@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stuart.yoder@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.