Re: [Qemu-devel] [PATCH v3 3/5] block/ssh: Add InetSocketAddress and accept it

[Kevin Wolf <kwolf@redhat.com>]

Am 17.10.2016 um 19:32 hat Ashijeet Acharya geschrieben:
> Add InetSocketAddress compatibility to SSH driver.
> 
> Add a new option "server" to the SSH block driver which then accepts
> a InetSocketAddress.
> 
> "host" and "port" are supported as legacy options and are mapped to
> their InetSocketAddress representation.
> 
> Signed-off-by: Ashijeet Acharya <ashijeetacharya@gmail.com>

> @@ -603,12 +661,21 @@ static int connect_to_ssh(BDRVSSHState *s, QDict *options,
>          host_key_check = "yes";
>      }
>  
> -    /* Construct the host:port name for inet_connect. */
> -    g_free(s->hostport);
> -    s->hostport = g_strdup_printf("%s:%d", host, port);

s->hostport isn't set any more now, so it should be removed from
BDRVSSHState. There is one user left, a warning message in
unsafe_flush_warning(), which should be converted to access s->inet
instead.

Kevin