From: Wolfram Sang <wsa@the-dreams.de>
To: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Cc: linux-i2c@vger.kernel.org,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Jukka Laitinen <jukka.laitinen@intel.com>
Subject: Re: [PATCH] i2c: designware: Avoid aborted transfers with fast reacting I2C slaves
Date: Tue, 25 Oct 2016 12:10:14 +0200 [thread overview]
Message-ID: <20161025101014.GI1597@katana> (raw)
In-Reply-To: <20160929130459.11345-1-jarkko.nikula@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 902 bytes --]
On Thu, Sep 29, 2016 at 04:04:59PM +0300, Jarkko Nikula wrote:
> I2C DesignWare may abort transfer with arbitration lost if I2C slave pulls
> SDA down quickly after falling edge of SCL. Reason for this is unknown but
> after trial and error it was found this can be avoided by enabling non-zero
> SDA RX hold time for the receiver.
>
> By the specification SDA RX hold time extends incoming SDA low to high
> transition by n * ic_clk cycles but only when SCL is high. However it
> seems to help avoid above faulty arbitration lost error.
>
> Bits 23:16 in IC_SDA_HOLD register define the SDA RX hold time for the
> receiver. Be conservative and enable 1 ic_clk cycle long hold time in
> case boot firmware hasn't set it up.
>
> Reported-by: Jukka Laitinen <jukka.laitinen@intel.com>
> Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Applied to for-current, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2016-10-25 10:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-29 13:04 [PATCH] i2c: designware: Avoid aborted transfers with fast reacting I2C slaves Jarkko Nikula
2016-09-30 7:05 ` Jukka Laitinen
2016-10-25 10:10 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161025101014.GI1597@katana \
--to=wsa@the-dreams.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=jukka.laitinen@intel.com \
--cc=linux-i2c@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.