From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44947) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bz0x6-0006kK-Sw for qemu-devel@nongnu.org; Tue, 25 Oct 2016 08:35:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bz0x3-0003H4-BP for qemu-devel@nongnu.org; Tue, 25 Oct 2016 08:35:36 -0400 Received: from 13.mo6.mail-out.ovh.net ([188.165.56.124]:55079) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1bz0x3-0003GB-54 for qemu-devel@nongnu.org; Tue, 25 Oct 2016 08:35:33 -0400 Received: from player786.ha.ovh.net (b7.ovh.net [213.186.33.57]) by mo6.mail-out.ovh.net (Postfix) with ESMTP id B257055C54 for ; Tue, 25 Oct 2016 14:35:31 +0200 (CEST) Date: Tue, 25 Oct 2016 14:35:20 +0200 From: Greg Kurz Message-ID: <20161025143520.4bf3b666@bahia> In-Reply-To: <1477285201-10244-6-git-send-email-david@gibson.dropbear.id.au> References: <1477285201-10244-1-git-send-email-david@gibson.dropbear.id.au> <1477285201-10244-6-git-send-email-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCHv5 05/12] tests: Adjust tco-test to use qpci_legacy_iomap() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, qemu-ppc@nongnu.org, lvivier@redhat.com, agraf@suse.de, stefanha@redhat.com, mst@redhat.com, aik@ozlabs.ru, mdroth@linux.vnet.ibm.com, thuth@redhat.com On Mon, 24 Oct 2016 15:59:54 +1100 David Gibson wrote: > Avoid tco-test making assumptions about the internal format of the address > tokens passed to PCI IO accessors, by using the new qpci_legacy_iomap() > function. > > Signed-off-by: David Gibson > Reviewed-by: Laurent Vivier > --- Reviewed-by: Greg Kurz > tests/tco-test.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/tco-test.c b/tests/tco-test.c > index 0d201b1..129577d 100644 > --- a/tests/tco-test.c > +++ b/tests/tco-test.c > @@ -70,7 +70,7 @@ static void test_init(TestData *d) > /* set Root Complex BAR */ > qpci_config_writel(d->dev, ICH9_LPC_RCBA, RCBA_BASE_ADDR | 0x1); > > - d->tco_io_base = (void *)((uintptr_t)PM_IO_BASE_ADDR + 0x60); > + d->tco_io_base = qpci_legacy_iomap(d->dev, PM_IO_BASE_ADDR + 0x60); > } > > static void stop_tco(const TestData *d)