From: Oleg Nesterov <oleg@redhat.com>
To: Roman Penyaev <roman.penyaev@profitbricks.com>
Cc: Andy Lutomirski <luto@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Tejun Heo <tj@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/1] workqueue: ignore dead tasks in a workqueue sleep hook
Date: Tue, 25 Oct 2016 17:57:12 +0200 [thread overview]
Message-ID: <20161025155712.GA12546@redhat.com> (raw)
In-Reply-To: <20161025141920.GC4326@redhat.com>
On 10/25, Oleg Nesterov wrote:
>
> void oops_end_exit(void)
> {
> current->flags &= ~PF_WQ_WORKER;
> perhaps sonething else;
> }
>
> called by oops_end() before rewind_stack_do_exit() ?
and "perhaps sonething else" above should probably clear current->plug,
it likely points to "struct blk_plug" on stack.
and perhaps call task_work_run(). Currently only irq_thread() uses the
"destructor" work on stack, but think can have more users.
Oleg.
next prev parent reply other threads:[~2016-10-25 15:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-25 11:03 [PATCH v3 1/1] workqueue: ignore dead tasks in a workqueue sleep hook Roman Pen
2016-10-25 12:56 ` Oleg Nesterov
2016-10-25 13:00 ` Roman Penyaev
2016-10-25 14:19 ` Oleg Nesterov
2016-10-25 15:57 ` Oleg Nesterov [this message]
2016-10-25 16:08 ` Oleg Nesterov
2016-10-25 18:15 ` Roman Penyaev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161025155712.GA12546@redhat.com \
--to=oleg@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=roman.penyaev@profitbricks.com \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.