From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sam Ravnborg Date: Tue, 25 Oct 2016 19:16:26 +0000 Subject: Re: [PATCH 09/11] sparc64: Convert U3copy_{from,to}_user to accurate exception reporting. Message-Id: <20161025191626.GA2143@ravnborg.org> List-Id: References: <20161025.110228.1744774836277392991.davem@davemloft.net> In-Reply-To: <20161025.110228.1744774836277392991.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: sparclinux@vger.kernel.org On Tue, Oct 25, 2016 at 03:07:56PM -0400, David Miller wrote: > From: Sam Ravnborg > Date: Tue, 25 Oct 2016 20:39:40 +0200 > > > One small comment below. > ... > >> @@ -22,21 +23,17 @@ > >> #endif > >> > >> #ifndef EX_LD > >> -#define EX_LD(x) x > >> +#define EX_LD(x,y) x > > > > The above line will result in following assembelr code fragment: > > .word 98b, ; \ > > ^ > > empty > > Maybe this is just fine - but it looks wrong. > > Same goes for other uses of related macros. > > It's a macro definition which just emits the first argument > when actually used. > > Can you explain in more detail what you think happens? Thats simple - I am wasting your time. I misread what was going on - and was too quick to reply. Sam