Re: [PATCH] clk/samsung: Clear OF_POPULATED flag from clkout node in init callback

[Stephen Boyd <sboyd@codeaurora.org>]

On 10/25, Marek Szyprowski wrote:
> diff --git a/drivers/clk/samsung/clk-exynos-clkout.c b/drivers/clk/samsung/clk-exynos-clkout.c
> index 96fab6cfb202..57303cfec7d4 100644
> --- a/drivers/clk/samsung/clk-exynos-clkout.c
> +++ b/drivers/clk/samsung/clk-exynos-clkout.c
> @@ -116,6 +116,12 @@ static void __init exynos_clkout_init(struct device_node *node, u32 mux_mask)
>  
>  	register_syscore_ops(&exynos_clkout_syscore_ops);
>  
> +	/*
> +	 * Clear the OF_POPULATED flag set in of_irq_init so that

This comment is incorrect. This code is clearing the flag set in
of_clk_init() right?

> +	 * later the Exynos PMU platform device won't be skipped.
> +	 */
> +	of_node_clear_flag(node, OF_POPULATED);
> +
>  	return;
>  

We have a macro for this in clk land. CLK_OF_DECLARE_DRIVER. Can
you use that instead please? It makes things like grep much
easier.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project