From: Dave Chinner <david@fromorbit.com>
To: Eryu Guan <eguan@redhat.com>
Cc: fstests@vger.kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH v2] xfs/054: only filter ROOT_INO at the beginning
Date: Wed, 26 Oct 2016 08:06:04 +1100 [thread overview]
Message-ID: <20161025210604.GC14023@dastard> (raw)
In-Reply-To: <1477402729-13934-1-git-send-email-eguan@redhat.com>
On Tue, Oct 25, 2016 at 09:38:49PM +0800, Eryu Guan wrote:
> In the test ROOT_INO is filtered out and/or replaced, but if
> ROOT_INO is also 32, more "32"s are filtered and replaced than
> expected. This happens to me when testing 512B block size XFS and 1k
> block size CRC enabled XFS.
>
> Fix it by filtering out only ROOT_INO at the beginning of a line,
> and removing all "g" modifiers in sed expressions.
>
> Also the ROOT_INO should be the root inode number of TEST_DIR not
> SCRATCH_MNT.
>
> Signed-off-by: Eryu Guan <eguan@redhat.com>
Looks fine.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
prev parent reply other threads:[~2016-10-25 21:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-25 13:38 [PATCH v2] xfs/054: only filter ROOT_INO at the beginning Eryu Guan
2016-10-25 21:06 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161025210604.GC14023@dastard \
--to=david@fromorbit.com \
--cc=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.