All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] core/graph-depends: add option to graph reverse dependencies
Date: Tue, 25 Oct 2016 23:56:09 +0200	[thread overview]
Message-ID: <20161025215609.GA3450@free.fr> (raw)
In-Reply-To: <20161025230434.2a2a69b1@free-electrons.com>

Thomas, All,

On 2016-10-25 23:04 +0200, Thomas Petazzoni spake thusly:
> On Sun, 23 Oct 2016 19:19:44 +0200, Yann E. MORIN wrote:
> > Now that we can dump the reverse dependencies of a package, add the
> > ability to graph those.
[--SNIP--]
> I've applied, thanks. However, our logic that gets rid of "redundant"
> dependencies also has the consequence of creating some graphs that are
> quite weird.
> 
> I tested a configuration where I enabled python and libglib2, both of
> which depend on libffi. When you do:
> 
> $ make libffi-show-rdepends
> 
> You get as expected "libglib2 python"
> 
> However, when you do
> 
> $ make libffi-graph-rdepends
> 
> The resulting graph is a bit weird. You would expect something like
> this:
> 
>            libffi
>        ------/ \------
>        |             |
>     libglib2       python

make BR2_GRAPH_DEPS_OPTS='--transitive -d1' libffi-graph-rdepends
would give you the expected graph.

But using options is not what you want. ;-)

> But instead, what you get is:
> 
>   libffi
>     /\
>     ||
>    python
>     /\
>     ||
>  util-linux
>     /\
>     ||
>   libglib2
> 
> Because indeed libglib2 depends on util-linux, and util-linux can
> optionally build python bindings and therefore depend on python.
> 
> Not sure what we can do about this: keeping all dependencies was really
> creating huge and unreadable graphs.

Well, that's the crux of the issue: keeping the whole graph is quickly
unworkable with even non-complex configurations.

Maybe what we should stress is that the graph-depends and graph-rdepends
display the build-order dependencies.

But yes, the apparent discrepancies between foo-show-rdepends and
foo-graph-rdepends can look weird on first sight, but both are correct.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2016-10-25 21:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-23 15:28 [Buildroot] [PATCHv2] pkg-infra: allow dumping reverse dependencies of a package Yann E. MORIN
2016-10-23 17:19 ` [Buildroot] [PATCH] core/graph-depends: add option to graph reverse dependencies Yann E. MORIN
2016-10-25 21:04   ` Thomas Petazzoni
2016-10-25 21:56     ` Yann E. MORIN [this message]
2016-10-25 20:57 ` [Buildroot] [PATCHv2] pkg-infra: allow dumping reverse dependencies of a package Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161025215609.GA3450@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.