From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S941594AbcJZV36 (ORCPT ); Wed, 26 Oct 2016 17:29:58 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:42258 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S936356AbcJZV3w (ORCPT ); Wed, 26 Oct 2016 17:29:52 -0400 Date: Wed, 26 Oct 2016 17:29:09 -0400 (EDT) Message-Id: <20161026.172909.588275737782880653.davem@davemloft.net> To: stefanr@s5r6.in-berlin.de Cc: netdev@vger.kernel.org, linux1394-devel@lists.sourceforge.net, jarod@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 1/2] firewire: net: fix maximum possible MTU From: David Miller In-Reply-To: <20161023162903.4166a35d@kant> References: <20161022212759.228c7642@kant> <20161023011824.GE32569@redhat.com> <20161023162903.4166a35d@kant> X-Mailer: Mew version 6.7 on Emacs 25.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 26 Oct 2016 14:29:11 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Stefan Richter Date: Sun, 23 Oct 2016 16:29:03 +0200 > Commit b3e3893e1253 ("net: use core MTU range checking in misc drivers") > mistakenly introduced an upper limit for firewire-net's MTU based on the > local link layer controller's reception capability. Revert this. Neither > RFC 2734 nor our implementation impose any particular upper limit. > > Actually, to be on the safe side and to make the code explicit, set > ETH_MAX_MTU = 65535 as upper limit now. > > (I replaced sizeof(struct rfc2734_header) by the equivalent > RFC2374_FRAG_HDR_SIZE in order to avoid distracting long/int conversions.) > > Fixes: b3e3893e1253('net: use core MTU range checking in misc drivers') > CC: netdev@vger.kernel.org > CC: linux1394-devel@lists.sourceforge.net > CC: Jarod Wilson > Signed-off-by: Stefan Richter Applied. From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next 1/2] firewire: net: fix maximum possible MTU Date: Wed, 26 Oct 2016 17:29:09 -0400 (EDT) Message-ID: <20161026.172909.588275737782880653.davem@davemloft.net> References: <20161022212759.228c7642@kant> <20161023011824.GE32569@redhat.com> <20161023162903.4166a35d@kant> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, linux1394-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, jarod@redhat.com To: stefanr@s5r6.in-berlin.de Return-path: In-Reply-To: <20161023162903.4166a35d@kant> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux1394-devel-bounces@lists.sourceforge.net List-Id: netdev.vger.kernel.org From: Stefan Richter Date: Sun, 23 Oct 2016 16:29:03 +0200 > Commit b3e3893e1253 ("net: use core MTU range checking in misc drivers") > mistakenly introduced an upper limit for firewire-net's MTU based on the > local link layer controller's reception capability. Revert this. Neither > RFC 2734 nor our implementation impose any particular upper limit. > > Actually, to be on the safe side and to make the code explicit, set > ETH_MAX_MTU = 65535 as upper limit now. > > (I replaced sizeof(struct rfc2734_header) by the equivalent > RFC2374_FRAG_HDR_SIZE in order to avoid distracting long/int conversions.) > > Fixes: b3e3893e1253('net: use core MTU range checking in misc drivers') > CC: netdev@vger.kernel.org > CC: linux1394-devel@lists.sourceforge.net > CC: Jarod Wilson > Signed-off-by: Stefan Richter Applied. ------------------------------------------------------------------------------ The Command Line: Reinvented for Modern Developers Did the resurgence of CLI tooling catch you by surprise? Reconnect with the command line and become more productive. Learn the new .NET and ASP.NET CLI. Get your free copy! http://sdm.link/telerik