From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39818) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bzFoV-0003bA-CY for qemu-devel@nongnu.org; Wed, 26 Oct 2016 00:27:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bzFoU-0006aN-1l for qemu-devel@nongnu.org; Wed, 26 Oct 2016 00:27:43 -0400 Date: Wed, 26 Oct 2016 15:27:28 +1100 From: David Gibson Message-ID: <20161026042728.GY11052@umbus.fritz.box> References: <1477285201-10244-1-git-send-email-david@gibson.dropbear.id.au> <20161025033552.GT11052@umbus.fritz.box> <20161025151400.404e52aa@bahia> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="+2xxXFcoH1/fp7Az" Content-Disposition: inline In-Reply-To: <20161025151400.404e52aa@bahia> Subject: Re: [Qemu-devel] [PATCHv5 00/12] Cleanups to qtest PCI handling List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Greg Kurz Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, qemu-ppc@nongnu.org, lvivier@redhat.com, agraf@suse.de, stefanha@redhat.com, mst@redhat.com, aik@ozlabs.ru, mdroth@linux.vnet.ibm.com, thuth@redhat.com --+2xxXFcoH1/fp7Az Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Oct 25, 2016 at 03:14:00PM +0200, Greg Kurz wrote: > On Tue, 25 Oct 2016 14:35:52 +1100 > David Gibson wrote: >=20 > > On Mon, Oct 24, 2016 at 03:59:49PM +1100, David Gibson wrote: > > > This series contains a number of cleanups to the libqos code for > > > accessing PCI devices, and to tests which use it. > > >=20 > > > The general aim is to improve the consistency of semantics across > > > functions, and reduce the amount of intimate knowledge of the libqos > > > PCI layer needed by tests. > > >=20 > > > This should make it easier to write PCI tests which will be portable > > > to different guest machines with different PCI host bridge > > > arrangements. > > >=20 > > > This series is on top of my ppc-for-2.8 branch, since it contains > > > patches enabling the virtio tests on ppc, which would otherwise > > > conflict with the changes here. =20 > >=20 > > Greg, Alexey, Michael, > >=20 > > Some reviews from outside RH would be really welcome. > >=20 >=20 > Done. >=20 > I also took time to run 'make check' with all targets on ppc64le, ppc64be, > i686 and ppc32 hosts. >=20 > Everything passes for ppc64le, ppc64be and i686. >=20 > It fails on ppc32 but this seems to be a TCG issue (QEMU fails with SIGILL > in code_gen_buffer()), not related to this patchset. >=20 > Tested-by: Greg Kurz Thanks for the reviews; I've now merged this into ppc-for-2.8. >=20 > > >=20 > > > Changes since v4: > > > * Fixed some remaining abstraction breaks in ahci-test > > > * Removed QPCI_BAR_INVALID, turned out not to really be useful > > >=20 > > > Changes since v3: > > > * Fixed another endian bug introduced in ide-test > > >=20 > > > Changes since v2: > > > * Fixed build bugs in virtio-9p-test, which I didn't find earlier > > > due to not having the right libraries installed > > > * Fixed an endian bug I accidentally introduced in ide-test > > > * Better handling of invalid BAR tokens > > >=20 > > > Changes since v1: > > > * Split out updates to tco-test into separate patch > > > * Split out updates to ide-test into separate patch > > > * Neater and more general handling of legacy PIO addresses > > > * Removed now-redundant fields from platform specific bus structures > > > * Introduced CONFIG_BASE() macro to virtio-pci to remove many > > > similar assignments > > > * Fixed handling of two guest testcasesin ivshmem > > > * Added 64-bit accessors > > > * Rebase on ppc-for-2.8 to avoid conflict with Laurent's series in > > > the same area > > >=20 > > > David Gibson (12): > > > libqos: Give qvirtio_config_read*() consistent semantics > > > libqos: Handle PCI IO de-multiplexing in common code > > > libqos: Move BAR assignment to common code > > > libqos: Better handling of PCI legacy IO > > > tests: Adjust tco-test to use qpci_legacy_iomap() > > > libqos: Add streaming accessors for PCI MMIO > > > libqos: Implement mmio accessors in terms of mem{read,write} > > > tests: Clean up IO handling in ide-test > > > libqos: Add 64-bit PCI IO accessors > > > tests: Use qpci_mem{read,write} in ivshmem-test > > > tests: Don't assume structure of PCI IO base in ahci-test > > > libqos: Change PCI accessors to take opaque BAR handle > > >=20 > > > tests/ahci-test.c | 13 +-- > > > tests/e1000e-test.c | 7 +- > > > tests/ide-test.c | 177 +++++++++++++++++++++++++++--------= ------ > > > tests/ivshmem-test.c | 47 +++++++---- > > > tests/libqos/ahci.c | 4 +- > > > tests/libqos/ahci.h | 7 +- > > > tests/libqos/pci-pc.c | 187 ++++++++++-------------------------= -------- > > > tests/libqos/pci-spapr.c | 194 ++++++++++++-----------------------= ---------- > > > tests/libqos/pci.c | 194 +++++++++++++++++++++++++++++++++++= ++-------- > > > tests/libqos/pci.h | 66 ++++++++++----- > > > tests/libqos/usb.c | 6 +- > > > tests/libqos/usb.h | 2 +- > > > tests/libqos/virtio-mmio.c | 16 ++-- > > > tests/libqos/virtio-pci.c | 122 ++++++++++++++-------------- > > > tests/libqos/virtio-pci.h | 2 +- > > > tests/rtl8139-test.c | 10 +-- > > > tests/tco-test.c | 80 +++++++++---------- > > > tests/usb-hcd-ehci-test.c | 5 +- > > > tests/virtio-9p-test.c | 8 +- > > > tests/virtio-blk-test.c | 42 +++------- > > > tests/virtio-scsi-test.c | 4 +- > > > 21 files changed, 598 insertions(+), 595 deletions(-) > > > =20 > >=20 >=20 --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --+2xxXFcoH1/fp7Az Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJYEDCvAAoJEGw4ysog2bOSUagQANYYkTzQJ0yyxeAGC2Y01zb8 ivcSzuQMNgOq4q28smQuYgVG9wmsgLw95YuRIFfTmvWchnE6kEkXT26s4DIVtm0S bKjerpi91IEnW9evDMJtxJKLr0/6XacumuqoAipFC2Rkc8p1Y1JnzvZLbZJz9dvF 4OxTsbOUUZKBFRLwF2864+jDEta/HUzyApcxhzBdgCe1du+Y3I407HoG6dA94A8s Jgf5/FWnmFa0tCuRVC+Qt9e/IydJXQ0libD4vnmZ3qT666R5VmfEX/8/ufQLbx2L JEWTkEyyt2XOcebIoN1BVT8lu8e/hvSw054xxYPD1mfLR/shYC/fxAFoMYUKS16v wb0noi0LOAfZ5S6Um3zLz15bzMWgg0I/ayyRdfylkizMsR8YPn4HuSIxy6tjAze9 1e0nEV/QDD5L4D4T8liKYL8rGKWrZgpBWuQoYWfhHUZadiVKQl7+uoqvf16m4tRR pMfgw8z8spCfuXomAzqsVdrFCiNsPtX65LHLURvZp1yPBMxBJM1Sppmx4ymhx35f nmbtMswIgdpmonqBsD+vWV6SbDFivQ+26fWsUD+Tv3aIn0JN0OmR5x603HzJ9WJg TRyQ5oc0XN690z7Fckr6JbrQ5fSk/8YMn4sFA2nXdIYt5F6x8Ys7wG87YRpyzY68 5/X9PijDaVWMw0zaazSz =5pyc -----END PGP SIGNATURE----- --+2xxXFcoH1/fp7Az--