From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53100) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bzGuO-0001MX-1b for qemu-devel@nongnu.org; Wed, 26 Oct 2016 01:37:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bzGuK-0001YW-VF for qemu-devel@nongnu.org; Wed, 26 Oct 2016 01:37:52 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43982) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1bzGuK-0001YN-Pn for qemu-devel@nongnu.org; Wed, 26 Oct 2016 01:37:48 -0400 Date: Wed, 26 Oct 2016 11:07:44 +0530 From: Amit Shah Message-ID: <20161026053744.GH1679@amit-lp.rh> References: <1476792613-11712-1-git-send-email-zhang.zhanghailiang@huawei.com> <1476792613-11712-9-git-send-email-zhang.zhanghailiang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1476792613-11712-9-git-send-email-zhang.zhanghailiang@huawei.com> Subject: Re: [Qemu-devel] [PATCH COLO-Frame (Base) v21 08/17] COLO: Send PVM state to secondary side when do checkpoint List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: zhanghailiang Cc: quintela@redhat.com, qemu-devel@nongnu.org, dgilbert@redhat.com, wency@cn.fujitsu.com, lizhijian@cn.fujitsu.com, xiecl.fnst@cn.fujitsu.com, Gonglei On (Tue) 18 Oct 2016 [20:10:04], zhanghailiang wrote: > VM checkpointing is to synchronize the state of PVM to SVM, just > like migration does, we re-use save helpers to achieve migrating > PVM's state to Secondary side. > > COLO need to cache the data of VM's state in the secondary side before > synchronize it to SVM. COLO need the size of the data to determine > how much data should be read in the secondary side. > So here, we can get the size of the data by saving it into I/O channel > before send it to the secondary side. BTW PVM and SVM and Primary and Secondary are used interchangeably and inconsistently. I'd prefer if you stuck with one usage. I prefer Primary and Secondary, but it doesn't matter what you choose. Amit