From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53445) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bzGwo-0002fV-1h for qemu-devel@nongnu.org; Wed, 26 Oct 2016 01:40:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bzGwn-00021k-93 for qemu-devel@nongnu.org; Wed, 26 Oct 2016 01:40:22 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54824) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1bzGwn-00020p-4Q for qemu-devel@nongnu.org; Wed, 26 Oct 2016 01:40:21 -0400 Date: Wed, 26 Oct 2016 11:10:17 +0530 From: Amit Shah Message-ID: <20161026054017.GI1679@amit-lp.rh> References: <1476792613-11712-1-git-send-email-zhang.zhanghailiang@huawei.com> <1476792613-11712-10-git-send-email-zhang.zhanghailiang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1476792613-11712-10-git-send-email-zhang.zhanghailiang@huawei.com> Subject: Re: [Qemu-devel] [PATCH COLO-Frame (Base) v21 09/17] COLO: Load VMState into QIOChannelBuffer before restore it List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: zhanghailiang Cc: quintela@redhat.com, qemu-devel@nongnu.org, dgilbert@redhat.com, wency@cn.fujitsu.com, lizhijian@cn.fujitsu.com, xiecl.fnst@cn.fujitsu.com, Gonglei On (Tue) 18 Oct 2016 [20:10:05], zhanghailiang wrote: > We should not destroy the state of SVM (Secondary VM) until we receive > the complete data of PVM's state, in case the primary fails in the process > of sending the state, so we cache the VM's state in secondary side before > load it into SVM. > > Besides, we should call qemu_system_reset() before load VM state, > which can ensure the data is intact. > > Signed-off-by: zhanghailiang > Signed-off-by: Li Zhijian > Signed-off-by: Gonglei > Reviewed-by: Dr. David Alan Gilbert > Cc: Dr. David Alan Gilbert Reviewed-by: Amit Shah Amit